Page MenuHomePhabricator

[clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix
ClosedPublic

Authored by vmiklos on Dec 21 2018, 2:19 PM.

Details

Summary

And also enable it by default to be consistent with e.g. modernize-use-using.

This helps e.g. when running this check on client code where the macro is provided by the system, so there is no easy way to modify it.

Diff Detail

Repository
rL LLVM

Event Timeline

vmiklos created this revision.Dec 21 2018, 2:19 PM
lebedev.ri added inline comments.Dec 21 2018, 2:22 PM
test/clang-tidy/readability-uppercase-literal-suffix-integer-macro.cpp
2–3 ↗(On Diff #179354)

And the positive test?

vmiklos updated this revision to Diff 179371.Dec 21 2018, 3:08 PM
vmiklos marked 2 inline comments as done.
vmiklos added inline comments.
test/clang-tidy/readability-uppercase-literal-suffix-integer-macro.cpp
2–3 ↗(On Diff #179354)

Added a positive test now. :-)

lebedev.ri accepted this revision.Dec 24 2018, 2:33 AM

LG i guess.

This revision is now accepted and ready to land.Dec 24 2018, 2:33 AM
JonasToth accepted this revision.Dec 24 2018, 7:00 AM

LGTM, do you have commit rights?

This revision was automatically updated to reflect the committed changes.
vmiklos marked an inline comment as done.

LGTM, do you have commit rights?

Yes, thanks. Committed now.