This patch drops install targets for LLVMHello.so,
TestPlugin.so, and BugpointPasses.so.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
with this patch, cmake still failed when build LLVMgold in mingw
CMake Error at cmake/modules/AddLLVM.cmake:667 (install): install TARGETS given no LIBRARY DESTINATION for module target "LLVMgold". Call Stack (most recent call first): tools/gold/CMakeLists.txt:14 (add_llvm_library)
Comment Actions
Module libraries are always treated as LIBRARY targets. via https://cmake.org/cmake/help/v3.0/command/install.html, but D51748 marked as RUNTIME targets when build with mingw
Comment Actions
FWIW, this LGTM. Clearly make sure that any build issues are resolved, but the core idea makes sense to me so land it whenever ready.