Page MenuHomePhabricator

cmake: Don't install plugins used for examples or tests
ClosedPublic

Authored by tstellar on Dec 20 2018, 3:38 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

tstellar created this revision.Dec 20 2018, 3:38 PM

with this patch, cmake still failed when build LLVMgold in mingw

CMake Error at cmake/modules/AddLLVM.cmake:667 (install):
  install TARGETS given no LIBRARY DESTINATION for module target "LLVMgold".
Call Stack (most recent call first):
  tools/gold/CMakeLists.txt:14 (add_llvm_library)

Module libraries are always treated as LIBRARY targets. via https://cmake.org/cmake/help/v3.0/command/install.html, but D51748 marked as RUNTIME targets when build with mingw

Module libraries are always treated as LIBRARY targets. via https://cmake.org/cmake/help/v3.0/command/install.html, but D51748 marked as RUNTIME targets when build with mingw

Does D56004 fix the build failures?

chandlerc accepted this revision.Dec 23 2018, 12:03 AM

FWIW, this LGTM. Clearly make sure that any build issues are resolved, but the core idea makes sense to me so land it whenever ready.

This revision is now accepted and ready to land.Dec 23 2018, 12:03 AM
This revision was automatically updated to reflect the committed changes.