Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Module libraries are always treated as LIBRARY targets. via https://cmake.org/cmake/help/v3.0/command/install.html, but D51748 marked as RUNTIME targets when build with mingw

Dec 21 2018, 1:03 AM

SquallATF added a comment to D55965: cmake: Don't install plugins used for examples or tests.

with this patch, cmake still failed when build LLVMgold in mingw

CMake Error at cmake/modules/AddLLVM.cmake:667 (install):
  install TARGETS given no LIBRARY DESTINATION for module target "LLVMgold".
Call Stack (most recent call first):
  tools/gold/CMakeLists.txt:14 (add_llvm_library)

Dec 21 2018, 12:47 AM

SquallATF added a comment to D51748: cmake: Remove add_llvm_loadable_module().

this change broken mingw build.

CMake Error at cmake/modules/AddLLVM.cmake:667 (install):
  install TARGETS given no LIBRARY DESTINATION for module target
  "BugpointPasses".
Call Stack (most recent call first):
  tools/bugpoint-passes/CMakeLists.txt:17 (add_llvm_library)

Dec 21 2018, 12:37 AM

Dec 10 2018

SquallATF created D55537: Should not export public functions implemented in assembly when build static lib on Windows.

Dec 10 2018, 6:06 PM

Dec 8 2018

SquallATF added a comment to D53422: Support clang compiling under windows-gnu and windows-msvc.

@jlpeyton Please help me commit this patch and depend, I did not have permission to commit it

Dec 8 2018, 7:02 PM

Dec 7 2018

SquallATF updated the diff for D55407: [COFF]Correct .eh_frame name, let llvm tools such as llvm-dwarfdump can dump .eh_frame info.

remove llvm-dwarfdump duplicate test

Dec 7 2018, 7:18 PM

SquallATF updated the diff for D55407: [COFF]Correct .eh_frame name, let llvm tools such as llvm-dwarfdump can dump .eh_frame info.

add test ccase

Dec 7 2018, 2:05 AM

SquallATF added a comment to D55407: [COFF]Correct .eh_frame name, let llvm tools such as llvm-dwarfdump can dump .eh_frame info.

In D55407#1322626, @mstorsjo wrote:

Oh, and also, please add a test case. That should probably be easy to do with yaml2obj.

Dec 7 2018, 12:55 AM

SquallATF updated the diff for D55407: [COFF]Correct .eh_frame name, let llvm tools such as llvm-dwarfdump can dump .eh_frame info.

a better way map .eh_frame name

Dec 7 2018, 12:48 AM

Dec 6 2018

SquallATF created D55407: [COFF]Correct .eh_frame name, let llvm tools such as llvm-dwarfdump can dump .eh_frame info.

Dec 6 2018, 7:57 PM

Nov 5 2018

SquallATF abandoned D54102: Clang enable __float128 on x86 and x86_64.

Nov 5 2018, 10:29 PM

SquallATF added a reviewer for D54133: Fix `warning: unknown pragma ignored` for mingw target: mstorsjo.

Nov 5 2018, 6:12 PM

SquallATF created D54133: Fix `warning: unknown pragma ignored` for mingw target.

Nov 5 2018, 6:08 PM

SquallATF created D54102: Clang enable __float128 on x86 and x86_64.

Nov 5 2018, 6:14 AM

SquallATF updated the diff for D53422: Support clang compiling under windows-gnu and windows-msvc.

update patch

Nov 5 2018, 6:06 AM

Nov 1 2018

SquallATF added a comment to D53968: [LLD]fix windows mingw build with 'LLVM_LINK_LLVM_DYLIB' the lld will hang when exiting.

This bug only in shared dll, static build does not trigger this bug Here is a issue with another project here that is very similar to this one.
I create a small test code to reproduce the bug. I have tried use clang, MSVC and gcc,I post MSVC build command here.

cpptest.zip1 KBDownload

bug build, test program will hang when exiting.

cl /EHsc /LD cppdll.cpp /Fecppdllcl.dll
cl cppexe.cpp /Fecppexecl.exe /link cppdllcl.lib

static build does not have this bug

cl /EHsc cppexe.cpp cppdll.cpp -DSTATIC /Fecppdllcls.exe

Nov 1 2018, 4:41 PM

SquallATF updated the diff for D53422: Support clang compiling under windows-gnu and windows-msvc.

misc fix, forget commit -mrtm flag handle.

Nov 1 2018, 2:41 AM

SquallATF abandoned D53973: Support clang compiling under windows-gnu and windows-msvc.

commit miss

Nov 1 2018, 2:40 AM

SquallATF created D53973: Support clang compiling under windows-gnu and windows-msvc.

Nov 1 2018, 2:39 AM

Oct 31 2018

SquallATF created D53968: [LLD]fix windows mingw build with 'LLVM_LINK_LLVM_DYLIB' the lld will hang when exiting.

Oct 31 2018, 11:37 PM

Oct 26 2018

SquallATF abandoned D53752: [CMake] Convert paths to the right form in standalone builds on Windows.

Oct 26 2018, 2:36 AM

SquallATF created D53752: [CMake] Convert paths to the right form in standalone builds on Windows.

Oct 26 2018, 2:33 AM

Oct 24 2018

SquallATF added inline comments to D53567: [Support] Enable color diagnostics for mintty.

Oct 24 2018, 11:51 PM

SquallATF updated the diff for D53631: Fix libcxx build with MinGW winpthreads.

I created a patch to MinGW winpthreads, remove _LIBCPP_SAFE_STATIC winpthread block

Oct 24 2018, 11:39 PM

SquallATF updated the diff for D53567: [Support] Enable color diagnostics for mintty.

limit this change for mingw only

Oct 24 2018, 1:03 AM

Oct 23 2018

SquallATF updated the diff for D53567: [Support] Enable color diagnostics for mintty.

rewrite detect mintty, port from vim.

Oct 23 2018, 11:59 PM

SquallATF created D53631: Fix libcxx build with MinGW winpthreads.

Oct 23 2018, 6:33 PM

SquallATF updated the diff for D53567: [Support] Enable color diagnostics for mintty.

run clang-format

Oct 23 2018, 6:09 PM

SquallATF created D53569: [MinGW] Enable large file for mingw-w64.

Oct 23 2018, 6:28 AM

SquallATF created D53567: [Support] Enable color diagnostics for mintty.

Oct 23 2018, 6:23 AM

SquallATF retitled D53563: [MinGW]Support for multiarch runtimes layout from Support for multiarch runtimes layout to [MinGW]Support for multiarch runtimes layout.

Oct 23 2018, 5:37 AM

SquallATF created D53563: [MinGW]Support for multiarch runtimes layout.

Oct 23 2018, 5:36 AM

Oct 22 2018

SquallATF updated the diff for D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory.

add test

Oct 22 2018, 6:52 PM · Restricted Project

Oct 21 2018

SquallATF retitled D53479: [Cmake] Allowed OpenMP testing detect test compiler with same generator from [Cmake] Allowed OpenMP testing with same generator to [Cmake] Allowed OpenMP testing detect test compiler with same generator.

Oct 21 2018, 6:34 PM

SquallATF retitled D53422: Support clang compiling under windows-gnu and windows-msvc from Support clang compiling under windows to Support clang compiling under windows-gnu and windows-msvc.

Oct 21 2018, 7:36 AM

SquallATF updated the diff for D53422: Support clang compiling under windows-gnu and windows-msvc.

Support clang compiling under windows-gnu and windows-msvc

Oct 21 2018, 7:35 AM

SquallATF created D53480: remove duplicate omp_control_tool export to fix windows build.

Oct 21 2018, 7:34 AM

SquallATF created D53479: [Cmake] Allowed OpenMP testing detect test compiler with same generator.

Oct 21 2018, 7:32 AM

SquallATF retitled D53422: Support clang compiling under windows-gnu and windows-msvc from Support mingw-w64 build with clang to Support clang compiling under windows.

Oct 21 2018, 2:08 AM

SquallATF updated the summary of D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory.

Oct 21 2018, 1:58 AM · Restricted Project