This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Fix memory leak in ClangdTests.
ClosedPublic

Authored by hokein on Dec 14 2018, 4:37 AM.

Details

Summary

createInvocationFromCommandLine sets DisableFree to true by default,
which leads memory leak in clangd. The fix is to use the BuildCompilationInvocation
to create CI with the correct options (DisableFree is false).

Fix https://bugs.llvm.org/show_bug.cgi?id=39991.

Diff Detail

Repository
rL LLVM

Event Timeline

hokein created this revision.Dec 14 2018, 4:37 AM
hokein added a subscriber: dstenb.Dec 14 2018, 4:37 AM

With this patch applied we don't see any issues on our end. Thanks for the help!

kadircet accepted this revision.Dec 14 2018, 5:17 AM

LGTM, thanks!

This revision is now accepted and ready to land.Dec 14 2018, 5:17 AM
This revision was automatically updated to reflect the committed changes.