This is an archive of the discontinued LLVM Phabricator instance.

Differential D55378

[compiler-rt] [test] Add missing cmake include for building libFuzzer alone
ClosedPublic

Authored by mgorny on Dec 6 2018, 11:11 AM.

Details

Reviewers
phosek
george.karpenkov
vitalybuka
Commits
rGef4b600301e9: [test] Add missing cmake include for building libFuzzer alone
rCRT348524: [test] Add missing cmake include for building libFuzzer alone
rL348524: [test] Add missing cmake include for building libFuzzer alone
Summary

Include CompilerRTCompile in fuzzer tests explicitly. Otherwise, when
building only libFuzzer, CMake fails due to:

CMake Error at cmake/Modules/AddCompilerRT.cmake:395 (sanitizer_test_compile):
  Unknown CMake command "sanitizer_test_compile".
Call Stack (most recent call first):
  lib/fuzzer/tests/CMakeLists.txt:53 (generate_compiler_rt_tests)

Diff Detail

Event Timeline

mgorny created this revision.Dec 6 2018, 11:11 AM
Herald added subscribers: Restricted Project, llvm-commits, dberris. · View Herald TranscriptDec 6 2018, 11:11 AM
vitalybuka accepted this revision.Dec 6 2018, 11:18 AM
This revision is now accepted and ready to land.Dec 6 2018, 11:18 AM
Closed by commit rL348524: [test] Add missing cmake include for building libFuzzer alone (authored by mgorny). · Explain WhyDec 6 2018, 12:07 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: delcypher. · View Herald TranscriptDec 6 2018, 12:07 PM

Revision Contents

PathSize
lib/
fuzzer/
tests/
2 lines

Diff 177017

lib/fuzzer/tests/CMakeLists.txt

include(CompilerRTCompile)
set(LIBFUZZER_UNITTEST_CFLAGS set(LIBFUZZER_UNITTEST_CFLAGS
${COMPILER_RT_UNITTEST_CFLAGS} ${COMPILER_RT_UNITTEST_CFLAGS}
${COMPILER_RT_GTEST_CFLAGS} ${COMPILER_RT_GTEST_CFLAGS}
-I${COMPILER_RT_SOURCE_DIR}/lib/fuzzer -I${COMPILER_RT_SOURCE_DIR}/lib/fuzzer
-fno-rtti -fno-rtti
-O2) -O2)
if (APPLE) if (APPLE)
▲ Show 20 Lines • Show All 54 Lines • Show Last 20 Lines