Page MenuHomePhabricator

AMDGPU: Use an ABS32_LO relocation for SCRATCH_RSRC_DWORD1
ClosedPublic

Authored by nhaehnle on Dec 6 2018, 7:01 AM.

Details

Summary

Using HI here makes no logical sense, since the dword is only
32 bits to begin with.

Current Mesa master does not look at the relocation type at all,
so this change is fine. Future Mesa will rely on this, however.

Change-Id: I91085707834c4ac0370926602b93c94b90e44cb1

Diff Detail

Repository
rL LLVM

Event Timeline

nhaehnle created this revision.Dec 6 2018, 7:01 AM
arsenm added a comment.Dec 6 2018, 9:03 AM

I thought mesa was moving to stop using the relocations at all for this?

I thought mesa was moving to stop using the relocations at all for this?

Eventually I hope so, yes.

arsenm accepted this revision.Dec 7 2018, 2:18 PM

LGTM

This revision is now accepted and ready to land.Dec 7 2018, 2:18 PM
This revision was automatically updated to reflect the committed changes.