This is an archive of the discontinued LLVM Phabricator instance.

Differential D55343

[WebAssembly] Change event section code to 13
ClosedPublic

Authored by aheejin on Dec 5 2018, 3:02 PM.

Details

Reviewers
binji
sbc100
Commits
rG3e5cc0b6ef36: [WebAssembly] Change event section code to 13
rL348424: [WebAssembly] Change event section code to 13
Summary

We decided to change the event section code from 12 to 13 as new
DataCount section in the bulk memory operations proposal will take the
code 12 instead.

Diff Detail

Event Timeline

aheejin created this revision.Dec 5 2018, 3:02 PM
Herald added subscribers: llvm-commits, sunfish, jgravelle-google, dschuff. · View Herald TranscriptDec 5 2018, 3:02 PM
Harbormaster completed remote builds in B25743: Diff 176885.Dec 5 2018, 3:02 PM
aheejin added a comment.Dec 5 2018, 3:02 PM

Reference: https://github.com/WebAssembly/exception-handling/issues/70

sbc100 accepted this revision.Dec 5 2018, 3:11 PM
This revision is now accepted and ready to land.Dec 5 2018, 3:11 PM
Closed by commit rL348424: [WebAssembly] Change event section code to 13 (authored by aheejin). · Explain WhyDec 5 2018, 3:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
llvm/
BinaryFormat/
2 lines
test/
MC/
WebAssembly/
2 lines

Diff 176885

include/llvm/BinaryFormat/Wasm.h

Show First 20 Lines • Show All 193 Lines • ▼ Show 20 Linesenum : unsigned {
WASM_SEC_TABLE = 4, // Indirect function table and other tables WASM_SEC_TABLE = 4, // Indirect function table and other tables
WASM_SEC_MEMORY = 5, // Memory attributes WASM_SEC_MEMORY = 5, // Memory attributes
WASM_SEC_GLOBAL = 6, // Global declarations WASM_SEC_GLOBAL = 6, // Global declarations
WASM_SEC_EXPORT = 7, // Exports WASM_SEC_EXPORT = 7, // Exports
WASM_SEC_START = 8, // Start function declaration WASM_SEC_START = 8, // Start function declaration
WASM_SEC_ELEM = 9, // Elements section WASM_SEC_ELEM = 9, // Elements section
WASM_SEC_CODE = 10, // Function bodies (code) WASM_SEC_CODE = 10, // Function bodies (code)
WASM_SEC_DATA = 11, // Data segments WASM_SEC_DATA = 11, // Data segments
WASM_SEC_EVENT = 12 // Event declarations WASM_SEC_EVENT = 13 // Event declarations
}; };
// Type immediate encodings used in various contexts. // Type immediate encodings used in various contexts.
enum : unsigned { enum : unsigned {
WASM_TYPE_I32 = 0x7F, WASM_TYPE_I32 = 0x7F,
WASM_TYPE_I64 = 0x7E, WASM_TYPE_I64 = 0x7E,
WASM_TYPE_F32 = 0x7D, WASM_TYPE_F32 = 0x7D,
WASM_TYPE_F64 = 0x7C, WASM_TYPE_F64 = 0x7C,
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines

test/MC/WebAssembly/event-section.ll

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines
; CHECK-NEXT: SymbolTable: ; CHECK-NEXT: SymbolTable:
; CHECK: - Index: 1 ; CHECK: - Index: 1
; CHECK-NEXT: Kind: EVENT ; CHECK-NEXT: Kind: EVENT
; CHECK-NEXT: Name: __cpp_exception ; CHECK-NEXT: Name: __cpp_exception
; CHECK-NEXT: Flags: [ BINDING_WEAK ] ; CHECK-NEXT: Flags: [ BINDING_WEAK ]
; CHECK-NEXT: Event: 0 ; CHECK-NEXT: Event: 0
; SEC: Type: EVENT (0xC) ; SEC: Type: EVENT (0xD)
; SEC-NEXT: Size: 3 ; SEC-NEXT: Size: 3
; SEC-NEXT: Offset: 97 ; SEC-NEXT: Offset: 97