Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
I'd recomment another pass to reduce the now fully redundant () pairs around % string substitutions, but in principle LGTM.
| utils/token-delta.py | ||
|---|---|---|
| 189 | Please just use a normal for-loop here instead of join + list comprehension? | |
| utils/token-delta.py | ||
|---|---|---|
| 189 | The change you request is unrelated to that commit, I suggest we postpone it to another patch. | |
| docs/tools/dump_ast_matchers.py | ||
|---|---|---|
| 45 | urllib2 was correct | |
urllib2 was correct