This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Store path to vendor-specific headers in clang-headers target property
ClosedPublic

Authored by sgraenitz on Nov 30 2018, 8:18 AM.

Details

Summary

LLDB.framework wants a copy these headers. With this change LLDB can easily glob for the list of files:

get_target_property(clang_include_dir clang-headers RUNTIME_OUTPUT_DIRECTORY)
file(GLOB_RECURSE clang_vendor_headers RELATIVE ${clang_include_dir} "${clang_include_dir}/*")

By default RUNTIME_OUTPUT_DIRECTORY is unset for custom targets like clang-headers.
Not sure if there is a read&write property that matches the purpose better.

What do you think?

Diff Detail

Repository
rL LLVM

Event Timeline

sgraenitz created this revision.Nov 30 2018, 8:18 AM
JDevlieghere accepted this revision.Nov 30 2018, 8:24 AM

This makes sense to me. I'm don't know if there's a better property but I think this matches the intended use, so I think it is fine.

This revision is now accepted and ready to land.Nov 30 2018, 8:24 AM
This revision was automatically updated to reflect the committed changes.