Details
Diff Detail
Event Timeline
| test/Transforms/LoadStoreVectorizer/X86/correct-order.ll | ||
|---|---|---|
| 2 | Unclear to my why -aa-pipeline=basic-aa is needed with the new PM (otherwise if not used AAResult contains no AAs and the test fails) while with the legacy PM -basicaa was not needed. Actually not clear to me if the two options are to be considered equivalent. | |
LGTM.
| test/Transforms/LoadStoreVectorizer/X86/correct-order.ll | ||
|---|---|---|
| 2 | BasicAA is always available for function passes in legacy PM (see AAResultsWrapperPass::runOnFunction). | |
Thanks for reviewing :)
| test/Transforms/LoadStoreVectorizer/X86/correct-order.ll | ||
|---|---|---|
| 2 | In that case maybe we should have a -aa-pipeline=basic-aa option in all the .ll tests (I see that there are a few missing)? Not that it seems to matter for the tests passing but the pass has proven do depend on it for a few of them so might make sense. | |
| test/Transforms/LoadStoreVectorizer/X86/correct-order.ll | ||
|---|---|---|
| 2 | I'm not sure about this. | |
Unclear to my why -aa-pipeline=basic-aa is needed with the new PM (otherwise if not used AAResult contains no AAs and the test fails) while with the legacy PM -basicaa was not needed. Actually not clear to me if the two options are to be considered equivalent.