Page MenuHomePhabricator

[PowerPC] Add Itineraries for STWU/STWUX etc
ClosedPublic

Authored by jsji on Nov 19 2018, 7:30 AM.

Details

Summary

When doing some instruction scheduling work, we noticed some missing itineraries.

Before we switch to machine scheduler, those missing itineraries might not have impact to actually scheduling,
because we can still get same latency due to default values.

With machine scheduler, however, itineraries will have impact to scheduling.
eg: NumMicroOps will default to be 0 if there is NO itineraries for specific instruction class.
And most of the instruction class with itineraries will have NumMicroOps default to 1.

This will has impact on the count of RetiredMOps, affects the Pending/Available Queue,
then causing different scheduling or suboptimal scheduling further.

This patch is for STWU/STWUX (IIC_LdStStoreUpd ) for P8.

Since there are already multiple IIC for store update, this patch also merge
IIC_LdStSTDU/IIC_LdStStoreUpd to IIC_LdStSTU
IIC_LdStSTDUX to IIC_LdStSTUX

and we add a new testcase in https://reviews.llvm.org/D54699 to show the difference.

Diff Detail

Repository
rL LLVM

Event Timeline

jsji created this revision.Nov 19 2018, 7:30 AM
nemanjai accepted this revision.Nov 20 2018, 6:42 AM

LGTM.

This revision is now accepted and ready to land.Nov 20 2018, 6:42 AM
This revision was automatically updated to reflect the committed changes.