Since D18860 addresses the problem that some regions are not properly cleaned up, as explained in D18860#1294011, it's no longer necessary to clean them up manually. This patch removes the respective code from checkEndFunction and from checkPostCall for destructors. No functional change intended.
Details
Details
- Reviewers
dcoughlin xazax.hun a.sidorin george.karpenkov szepet rnkovacs - Commits
- rG6c0b2ce1be3b: [analyzer] MoveChecker: NFC: Remove the workaround for the "zombie symbols" bug.
rC348208: [analyzer] MoveChecker: NFC: Remove the workaround for the "zombie symbols" bug.
rL348208: [analyzer] MoveChecker: NFC: Remove the workaround for the "zombie symbols" bug.
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Bring back the early return for destructors. Cleaning up the state might be unnecessary, but calling a destructor on a moved object is still fine and should not cause a warning.
Add a test because this wasn't caught by tests.