Page MenuHomePhabricator

[CMake] Allow version overrides with -DLLDB_VERSION_MAJOR/MINOR/PATCH/SUFFIX
ClosedPublic

Authored by sgraenitz on Nov 9 2018, 10:50 AM.

Details

Summary

This follows the approach in Clang. If no overrides are given, LLDB_VERSION_* is inferred from LLVM_VERSION_*. This mimics the current behaviour (PACKAGE_VERSION itself is generated from LLVM_VERSION_*).
For in-tree builds LLVM_VERSION_* will be defined at this point already. For standalone builds, LLDBConfig.cmake is included after LLDBStandalone.cmake which includes LLVMConfig.cmake.

Diff Detail

Repository
rL LLVM

Event Timeline

sgraenitz created this revision.Nov 9 2018, 10:50 AM
sgraenitz added a subscriber: Restricted Project.Nov 9 2018, 11:08 AM
aprantl accepted this revision.Nov 9 2018, 12:48 PM
This revision is now accepted and ready to land.Nov 9 2018, 12:48 PM

Seems reasonable!

xiaobai accepted this revision.Nov 9 2018, 12:53 PM

Yep, this looks good to me. Thanks! :)

This revision was automatically updated to reflect the committed changes.