This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Add an option -disable-promote-alloca-to-lds
ClosedPublic

Authored by yaxunl on Nov 6 2018, 9:35 AM.

Details

Summary

Add this option for debugging and providing workaround.

By default it is off so no behavior change in backend.

Diff Detail

Event Timeline

yaxunl created this revision.Nov 6 2018, 9:35 AM
arsenm requested changes to this revision.Nov 6 2018, 9:46 AM

We already have a flag disable-promote-alloca-to-vector inside the pass itself. It would probably be more useful to add another corresponding one for the LDS promotion part if that's useful

This revision now requires changes to proceed.Nov 6 2018, 9:46 AM
yaxunl updated this revision to Diff 172804.Nov 6 2018, 11:26 AM
yaxunl retitled this revision from AMDGPU: Add an option amdgpu-enable-promote-alloca to enable/disable alloca to AMDGPU: Add an option -disable-promote-alloca-to-lds.
yaxunl edited the summary of this revision. (Show Details)

Revised by Matt's comments.

yaxunl updated this revision to Diff 172833.Nov 6 2018, 12:57 PM

add a test

arsenm accepted this revision.Nov 6 2018, 1:00 PM

LGTM

This revision is now accepted and ready to land.Nov 6 2018, 1:00 PM
This revision was automatically updated to reflect the committed changes.