Remove Java debugger plugin
ClosedPublic

Authored by JDevlieghere on Fri, Nov 2, 4:30 PM.

Details

Summary

In January Davide sent an e-mail to the mailing list to suggest removing support for Go and Java. The plan was to have some cool down period to allow users to speak up. However, the actual removal never took place. I decided to move forward and start the removal process.

Discussion on the mailing list: http://lists.llvm.org/pipermail/lldb-dev/2018-January/013171.html

Diff Detail

JDevlieghere created this revision.Fri, Nov 2, 4:30 PM

I was a little to eager, leave Language.cpp alone.

Minor detail: The revision title only mentions Java, but this revision removes both Go and Java.

Did anyone actually went through with Jim's proposal and posted this proposal to some Go mailing list or so?

Minor detail: The revision title only mentions Java, but this revision removes both Go and Java.

Actually, this review is only for removing the Java plugin. There’s a different review for the Go plugin: D54057.

I suppose the confusion is the result of the first file removing both enum values. I’ll update the review.

Did anyone actually went through with Jim's proposal and posted this proposal to some Go mailing list or so?

I didn’t but I’m not sure about Davide. I’ll check with him on Monday.

Minor detail: The revision title only mentions Java, but this revision removes both Go and Java.

Did anyone actually went through with Jim's proposal and posted this proposal to some Go mailing list or so?

tberghammer accepted this revision.Mon, Nov 5, 1:55 AM

LGTM. Thank you for removing it.

source/Plugins/Process/minidump/MinidumpTypes.h
84

This is JavaScript and not Java. Also I think this is a constant what is coming from the minidump spec so I would leave it even after we removed Java support from LLDB.

155

I think this is a constant what is coming from the minidump spec so I would leave it even after we removed Java support from LLDB

This revision is now accepted and ready to land.Mon, Nov 5, 1:55 AM
davide added inline comments.Mon, Nov 5, 8:12 AM
tools/lldb-test/SystemInitializerTest.cpp
194

Aside, do you know why we have renderscript support? maybe that should go away too.

tberghammer added inline comments.Mon, Nov 5, 8:27 AM
tools/lldb-test/SystemInitializerTest.cpp
194

You should ask Stephen Hines (srhines@google.com) about that one as he either know what is its status or know who to ask,

This revision was automatically updated to reflect the committed changes.