Before:
% llvm-objcopy -help
...
--weaken-symbol=symbol Mark <symbol> as weak
--weaken-symbol symbol Mark <symbol> as weak
After:
% llvm-objcopy -help
...
--weaken-symbol=symbol Mark <symbol> as weak
Paths
| Differential D53983
[llvm-objcopy] For multiclass Eq, associate help text with --name= , not --name ClosedPublic Authored by MaskRay on Nov 1 2018, 9:49 AM.
Details Summary Before: After:
Diff Detail
Event TimelineComment Actions LGTM, although please make sure that the whitespace is tidied up a bit, to make the indentation consistent, and reduce the number of long lines.
This revision is now accepted and ready to land.Nov 1 2018, 10:11 AM Closed by commit rL345855: [llvm-objcopy] For multiclass Eq, associate help text with --name= , not with… (authored by MaskRay). · Explain WhyNov 1 2018, 10:22 AM This revision was automatically updated to reflect the committed changes. Comment Actions --help is getting to the point where it might be clean enough to write a test for :)
Revision Contents
Diff 172163 tools/llvm-objcopy/ObjcopyOpts.td
tools/llvm-objcopy/StripOpts.td
|
Might be worth on some of these long lines to break it over two lines, e.g:
or similar. Not sure about the indentation of the second line.