This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Expand inserts and extracts with variable indices
ClosedPublic

Authored by tlively on Oct 31 2018, 6:16 PM.

Diff Detail

Event Timeline

tlively created this revision.Oct 31 2018, 6:16 PM
aheejin accepted this revision.Nov 1 2018, 3:19 PM

Great that we can do this without doing crazy things! LGTM with one nit.

lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
1078

Maybe add comments on what this is supposed to do?

This revision is now accepted and ready to land.Nov 1 2018, 3:19 PM
tlively marked an inline comment as done.Nov 1 2018, 5:09 PM
tlively added inline comments.
lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
1078

Done. Also added tests for replace_lane.

This revision was automatically updated to reflect the committed changes.
tlively marked an inline comment as done.