Details
Diff Detail
Event Timeline
test/tools/llvm-objdump/common-symbol-elf.test | ||
---|---|---|
1 ↗ | (On Diff #171448) | I don't think this is the right place to add this sort of test. The test is specifically about common symbols, not about generic behaviour of the -t switch and how the command-line is handled. Perhaps a better thing to do would be something similar to what WebAssembly/symbol-table.test does, but add a new test for ELF, e.g. elf-symbol-table.test, which takes both arguments. |
I would suggest renaming the test to symbol-table-elf.test for consistency with other *-elf tests in this directory.
test/tools/llvm-objdump/elf-symbol-table.test | ||
---|---|---|
5 | I think this check should be removed because file format line is not the focus of this test. |
I agree with this, but I think a separate change might be worthwhile to rename all of the *-elf tests to elf-*, as that better matches the majority of the coff-* and macho-* tests.
Otherwise, looks good, with the suggestions @eush has made.
LG and improves test coverage as well.
Please mention if you need someone to land the patch on your behalf after review, makes it easier, especially for smaller patches.
Hi James, @jhenderson , could you please help me commit this patch? Thanks a lot :)
Thank you everyone :)
If you want I can test it and land it if there are no issues with the lit test. Will be a moment.
I think this check should be removed because file format line is not the focus of this test.