[llvm-objdump] add support for '--syms' as an alias of -t (PR39406)

[Higuoxing]

Summary

See: https://bugs.llvm.org/show_bug.cgi?id=39406

[jhenderson]

test/tools/llvm-objdump/common-symbol-elf.test

1

I don't think this is the right place to add this sort of test. The test is specifically about common symbols, not about generic behaviour of the -t switch and how the command-line is handled.

Perhaps a better thing to do would be something similar to what WebAssembly/symbol-table.test does, but add a new test for ELF, e.g. elf-symbol-table.test, which takes both arguments.

[Higuoxing]

Update test cases

[eush]

I would suggest renaming the test to symbol-table-elf.test for consistency with other *-elf tests in this directory.

test/tools/llvm-objdump/elf-symbol-table.test

5 ↗

(On Diff #171627)

I think this check should be removed because file format line is not the focus of this test.

[jhenderson]

In D53803#1279991, @eush wrote:

I would suggest renaming the test to symbol-table-elf.test for consistency with other *-elf tests in this directory.

I agree with this, but I think a separate change might be worthwhile to rename all of the *-elf tests to elf-*, as that better matches the majority of the coff-* and macho-* tests.

Otherwise, looks good, with the suggestions @eush has made.

[Higuoxing]

Thanks a lot!

[kristina]

LG and improves test coverage as well.

Please mention if you need someone to land the patch on your behalf after review, makes it easier, especially for smaller patches.

[Higuoxing]

Hi James, @jhenderson , could you please help me commit this patch? Thanks a lot :)

Thank you everyone :)

[kristina]

In D53803#1281705, @Higuoxing wrote:

Hi James, @jhenderson , could you please help me commit this patch? Thanks a lot :)

Thank you everyone :)

If you want I can test it and land it if there are no issues with the lit test. Will be a moment.

[Higuoxing]

In D53803#1281748, @kristina wrote:

In D53803#1281705, @Higuoxing wrote:

Hi James, @jhenderson , could you please help me commit this patch? Thanks a lot :)

Thank you everyone :)

If you want I can test it and land it if there are no issues with the lit test. Will be a moment.

Thanks a lot, please help me :-)

test/tools/llvm-objdump/common-symbol-elf.test

 // RUN: llvm-objdump -t %p/Inputs/common-symbol-elf | FileCheck %s
+// RUN: llvm-objdump --syms %p/Inputs/common-symbol-elf | FileCheck %s
 
 CHECK: 00000400 g       *COM*  00000008 common_symbol

tools/llvm-objdump/llvm-objdump.cpp

llvm::DynamicRelocations("dynamic-reloc",
   cl::desc("Display the dynamic relocation entries in the file"));
 static cl::alias
 DynamicRelocationsd("R", cl::desc("Alias for --dynamic-reloc"),
              cl::aliasopt(DynamicRelocations));
 
 cl::opt<bool>
 llvm::SectionContents("s", cl::desc("Display the content of each section"));
 
-cl::opt<bool>
-llvm::SymbolTable("t", cl::desc("Display the symbol table"));
+cl::opt<bool> llvm::SymbolTable("syms", cl::desc("Display the symbol table"));
+cl::alias SymbolTableShort("t", cl::desc("Alias for --syms"),
+                           cl::aliasopt(llvm::SymbolTable));
 
 cl::opt<bool>
 llvm::ExportsTrie("exports-trie", cl::desc("Display mach-o exported symbols"));
 
 cl::opt<bool>
 llvm::Rebase("rebase", cl::desc("Display mach-o rebasing info"));
 
 cl::opt<bool>