[llvm-objdump] add support for '--syms' as an alias of -t (PR39406)

[Higuoxing]

Summary

See: https://bugs.llvm.org/show_bug.cgi?id=39406

[jhenderson]

test/tools/llvm-objdump/common-symbol-elf.test

1 ↗

(On Diff #171448)

I don't think this is the right place to add this sort of test. The test is specifically about common symbols, not about generic behaviour of the -t switch and how the command-line is handled.

Perhaps a better thing to do would be something similar to what WebAssembly/symbol-table.test does, but add a new test for ELF, e.g. elf-symbol-table.test, which takes both arguments.

[Higuoxing]

Update test cases

[eush]

I would suggest renaming the test to symbol-table-elf.test for consistency with other *-elf tests in this directory.

test/tools/llvm-objdump/elf-symbol-table.test

5 ↗

(On Diff #171627)

I think this check should be removed because file format line is not the focus of this test.

[jhenderson]

In D53803#1279991, @eush wrote:

I would suggest renaming the test to symbol-table-elf.test for consistency with other *-elf tests in this directory.

I agree with this, but I think a separate change might be worthwhile to rename all of the *-elf tests to elf-*, as that better matches the majority of the coff-* and macho-* tests.

Otherwise, looks good, with the suggestions @eush has made.

[Higuoxing]

Thanks a lot!

[kristina]

LG and improves test coverage as well.

Please mention if you need someone to land the patch on your behalf after review, makes it easier, especially for smaller patches.

[Higuoxing]

Hi James, @jhenderson , could you please help me commit this patch? Thanks a lot :)

Thank you everyone :)

[kristina]

In D53803#1281705, @Higuoxing wrote:

Hi James, @jhenderson , could you please help me commit this patch? Thanks a lot :)

Thank you everyone :)

If you want I can test it and land it if there are no issues with the lit test. Will be a moment.

[Higuoxing]

In D53803#1281748, @kristina wrote:

In D53803#1281705, @Higuoxing wrote:

Hi James, @jhenderson , could you please help me commit this patch? Thanks a lot :)

Thank you everyone :)

If you want I can test it and land it if there are no issues with the lit test. Will be a moment.

Thanks a lot, please help me :-)

llvm/trunk/test/tools/llvm-objdump/symbol-table-elf.test

+# RUN: yaml2obj %s > %t
+# RUN: llvm-objdump --syms %t | FileCheck %s
+# RUN: llvm-objdump -t     %t | FileCheck %s
+
+# CHECK:      SYMBOL TABLE:
+# CHECK-NEXT: 0000000000000000         *UND*     00000000
+# CHECK-NEXT: 0000000000001004 l     F .text     00000000 lfoo
+# CHECK-NEXT: 0000000000001008 l       .text     00000000 lbar
+# CHECK-NEXT: 0000000000001004 g     F .text     00000000 foo
+# CHECK-NEXT: 0000000000001008 g       .text     00000000 bar
+
+!ELF
+FileHeader:
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
+  Type:            ET_EXEC
+  Machine:         EM_X86_64
+Sections:
+  - Name:            .bss
+    Type:            SHT_NOBITS
+    Flags:           [ SHF_ALLOC ]
+    AddressAlign:    0x0000000000000010
+    Size:            64
+  - Name:            .text
+    Type:            SHT_PROGBITS
+    Flags:           [ SHF_ALLOC, SHF_EXECINSTR ]
+    AddressAlign:    0x0000000000000010
+    Content:         "00000000"
+Symbols:
+   Global:
+     - Name:     foo
+       Type:     STT_FUNC
+       Section:  .text
+       Value:    0x1004
+     - Name:     bar
+       Type:     STT_OBJECT
+       Section:  .text
+       Value:    0x1008
+   Local:
+     - Name:     lfoo
+       Type:     STT_FUNC
+       Section:  .text
+       Value:    0x1004
+     - Name:     lbar
+       Type:     STT_OBJECT
+       Section:  .text
+       Value:    0x1008

llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp

 
 cl::opt<bool>
     llvm::SectionContents("full-contents",
                           cl::desc("Display the content of each section"));
 static cl::alias SectionContentsShort("s",
                                       cl::desc("Alias for --full-contents"),
                                       cl::aliasopt(SectionContents));
 
-cl::opt<bool>
-llvm::SymbolTable("t", cl::desc("Display the symbol table"));
+cl::opt<bool> llvm::SymbolTable("syms", cl::desc("Display the symbol table"));
+static cl::alias SymbolTableShort("t", cl::desc("Alias for --syms"),
+                                  cl::aliasopt(llvm::SymbolTable));
 
 cl::opt<bool>
 llvm::ExportsTrie("exports-trie", cl::desc("Display mach-o exported symbols"));
 
 cl::opt<bool>
 llvm::Rebase("rebase", cl::desc("Display mach-o rebasing info"));
 
 cl::opt<bool>