This is an archive of the discontinued LLVM Phabricator instance.

Differential D53648

[clangd] Only log ignored diagnostics with -log=verbose.
ClosedPublic

Authored by sammccall on Oct 24 2018, 7:58 AM.

Details

Reviewers
ilya-biryukov
Commits
rG3fd25fcf36aa: [clangd] Only log ignored diagnostics with -log=verbose.
rCTE345968: [clangd] Only log ignored diagnostics with -log=verbose.
rL345968: [clangd] Only log ignored diagnostics with -log=verbose.

Diff Detail

Event Timeline

sammccall created this revision.Oct 24 2018, 7:58 AM
Herald added subscribers: cfe-commits, kadircet, arphaman and 3 others. · View Herald TranscriptOct 24 2018, 7:58 AM
Harbormaster completed remote builds in B24154: Diff 170894.Oct 24 2018, 7:59 AM
ilya-biryukov accepted this revision.Oct 30 2018, 8:24 AM

LGTM

This revision is now accepted and ready to land.Oct 30 2018, 8:24 AM
ilya-biryukov added a comment.Oct 30 2018, 8:24 AM

Sorry for the delay, it was open in my browser for days...

Closed by commit rL345968: [clangd] Only log ignored diagnostics with -log=verbose. (authored by sammccall). · Explain WhyNov 2 2018, 5:54 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptNov 2 2018, 5:54 AM

Revision Contents

PathSize
clangd/
3 lines

Diff 170894

clangd/Compiler.cpp

Show All 14 Lines
#include "llvm/Support/FormatVariadic.h" #include "llvm/Support/FormatVariadic.h"
using namespace llvm; using namespace llvm;
namespace clang { namespace clang {
namespace clangd { namespace clangd {
void IgnoreDiagnostics::log(DiagnosticsEngine::Level DiagLevel, void IgnoreDiagnostics::log(DiagnosticsEngine::Level DiagLevel,
const clang::Diagnostic &Info) { const clang::Diagnostic &Info) {
// FIXME: format lazily, in case vlog is off.
SmallString<64> Message; SmallString<64> Message;
Info.FormatDiagnostic(Message); Info.FormatDiagnostic(Message);
SmallString<64> Location; SmallString<64> Location;
if (Info.hasSourceManager() && Info.getLocation().isValid()) { if (Info.hasSourceManager() && Info.getLocation().isValid()) {
auto &SourceMgr = Info.getSourceManager(); auto &SourceMgr = Info.getSourceManager();
auto Loc = SourceMgr.getFileLoc(Info.getLocation()); auto Loc = SourceMgr.getFileLoc(Info.getLocation());
raw_svector_ostream OS(Location); raw_svector_ostream OS(Location);
Loc.print(OS, SourceMgr); Loc.print(OS, SourceMgr);
OS << ":"; OS << ":";
} }
clangd::log("Ignored diagnostic. {0}{1}", Location, Message); clangd::vlog("Ignored diagnostic. {0}{1}", Location, Message);
} }
void IgnoreDiagnostics::HandleDiagnostic(DiagnosticsEngine::Level DiagLevel, void IgnoreDiagnostics::HandleDiagnostic(DiagnosticsEngine::Level DiagLevel,
const clang::Diagnostic &Info) { const clang::Diagnostic &Info) {
IgnoreDiagnostics::log(DiagLevel, Info); IgnoreDiagnostics::log(DiagLevel, Info);
} }
std::unique_ptr<CompilerInstance> prepareCompilerInstance( std::unique_ptr<CompilerInstance> prepareCompilerInstance(
Show All 40 Lines