[clangd] Remove the overflow log.

[hokein]

Summary

LLVM codebase has generated files (all are build/Target/XXX/*.inc) that
exceed the MaxLine & MaxColumn. Printing these log would be noisy.

[sammccall]

After looking at the examples, I'm reassured that we don't really care about tracking precise locations of those references :-)

I'd suggest adding the logging just to where the field is *read* in XRefs.cpp (check if it's max-value).
That would cover a bunch of the cases where an incorrect location is likely to be visible.

[hokein]

Add log in XRefs.cpp.

[sammccall]

Some nitty ideas about the log message, but whatever you think is best.

clangd/XRefs.cpp

43 ↗

(On Diff #170091)

Log message could use more context. And I think it'd be really useful to print the whole location here.

bikeshed: you could add a method bool Position::hasOverflow(), and then write below

if (LSPLoc.range.start.hasOverflow() || LSPLoc.range.end.hasOverflow())
  log("Possible overflow in symbol location: {0}", LSPLoc);

Distinguishing between line/column overflow isn't important if you're printing the full range anyway.

[hokein]

Log the whole location when overflow happens.

[hokein]

clangd/XRefs.cpp

43 ↗

(On Diff #170091)

This is neat.

[hokein]

Minor cleanup.

clangd/index/Index.cpp

 namespace clang {
 namespace clangd {
 using namespace llvm;
 
 constexpr uint32_t SymbolLocation::Position::MaxLine;
 constexpr uint32_t SymbolLocation::Position::MaxColumn;
 void SymbolLocation::Position::setLine(uint32_t L) {
   if (L > MaxLine) {
-    log("Set an overflowed Line {0}", L);
     Line = MaxLine;
     return;
   }
   Line = L;
 }
 void SymbolLocation::Position::setColumn(uint32_t Col) {
   if (Col > MaxColumn) {
-    log("Set an overflowed Column {0}", Col);
     Column = MaxColumn;
     return;
   }
   Column = Col;
 }
 
 raw_ostream &operator<<(raw_ostream &OS, const SymbolLocation &L) {
   if (!L)