This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Do not fuse VADD and VMUL, continued (2/2)
ClosedPublic

Authored by SjoerdMeijer on Oct 16 2018, 1:59 AM.

Details

Diff Detail

Event Timeline

SjoerdMeijer created this revision.Oct 16 2018, 1:59 AM
SjoerdMeijer retitled this revision from ARM] Do not fuse VADD and VMUL, continued (2/2) to [ARM] Do not fuse VADD and VMUL, continued (2/2).Oct 16 2018, 2:00 AM
samparker added inline comments.Oct 16 2018, 6:22 AM
test/CodeGen/ARM/fusedMAC.ll
10

should the f64 version not also be tested?

should the f64 version not also be tested?

Both the M4 and M33 have only Single-Precision VFP support. Thus f64 operations result in EABI calls and so I don't think there's much to test here. I have cleaned up the RUN line in the test case though as we only need the -mcpu=cortex-m33 part and not the other attributes.

Good point. Would it be worth adding a test for the M7 though? We seem to be a little lacking in our m-class FP tests.

test/CodeGen/ARM/fusedMAC.ll
2

this is a funny looking triple for the M33

Would it be worth adding a test for the M7 though? We seem to be a little lacking in our m-class FP tests.

Yep, agreed. Added tests for the M7 and M4.

this is a funny looking triple for the M33

Oops, copy-paste, but now fixed.

nhaehnle removed a subscriber: nhaehnle.Oct 16 2018, 8:18 AM
samparker accepted this revision.Oct 16 2018, 8:19 AM

Thanks, LGTM. With one bonus question, are the fused operations fast on the M7..?

This revision is now accepted and ready to land.Oct 16 2018, 8:19 AM
SjoerdMeijer added a comment.EditedOct 16 2018, 8:45 AM

Cheers

With one bonus question, are the fused operations fast on the M7..?

:-)

From a first glance, it looks like we should give the M7 a similar treatment.
But I will double check, also run benchmarks, and will follow-up if necessary (which, again, looks very likely).

This revision was automatically updated to reflect the committed changes.