This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Do not query index for new name completions.
ClosedPublic

Authored by kadircet on Oct 12 2018, 5:07 AM.

Event Timeline

kadircet created this revision.Oct 12 2018, 5:07 AM

(This looks good, of course the Sema patch needs to land first!)

clangd/CodeComplete.cpp
651

consider Recovery, NaturalLanguage there too? and maybe Other?

A drive-by NIT ;-)

clangd/CodeComplete.cpp
651

NIT: use FIXME to be consistent with the rest of clangd

kadircet updated this revision to Diff 170626.Oct 23 2018, 6:27 AM
  • Rebase and take in new changes.
kadircet updated this revision to Diff 170634.Oct 23 2018, 6:58 AM
kadircet marked 2 inline comments as done.
  • Address comments.
kadircet updated this revision to Diff 170678.Oct 23 2018, 9:26 AM
  • Use new enum types.
sammccall accepted this revision.Oct 24 2018, 8:02 AM
sammccall added inline comments.
unittests/clangd/CodeCompleteTests.cpp
2180

Any need to actually enable this option, or just copied from above test?

(If not, no need to pass opts at all, it'll be defaulted).

This revision is now accepted and ready to land.Oct 24 2018, 8:02 AM
kadircet updated this revision to Diff 170900.Oct 24 2018, 8:24 AM
kadircet marked an inline comment as done.
  • Change symbols name to get a match from index.
unittests/clangd/CodeCompleteTests.cpp
2180

Actually it was needed to check we don't add suggest items from cross namespaces, but I had an error in symbols name, changing that to start with "n" as well.

This revision was automatically updated to reflect the committed changes.