[clang-doc] Switch to default to all-TUs executor

[juliehockett]

Summary

Since we generally want to document a whole project, not just one file.

@ioeric, is this an acceptable way to do this? I want to be able to use any executor, but I'd like the default to be all-TUs instead of standalone.

[leonardchan]

clang-tools-extra/clang-doc/tool/ClangDocMain.cpp

90–92 ↗

(On Diff #169302)

I think this might be more than 80 characters in a line? Run clang-format just to be sure.

202–203 ↗

(On Diff #169302)

Formatting nit: Should the arguments be aligned here?

211–213 ↗

(On Diff #169302)

Nit: Remove braces

[Eugene.Zelenko]

clang-tools-extra/clang-doc/tool/ClangDocMain.cpp

205 ↗

(On Diff #169304)

Please don't use auto when type is not spelled in same statement.

209 ↗

(On Diff #169304)

Please use range loop.

[ioeric]

clang-tools-extra/clang-doc/tool/ClangDocMain.cpp

203 ↗

(On Diff #169304)

This is exposing too much implementation details.I landed a patch to expose the ExecutorName option from the library (rL344335) so you could simply do ExecutorName.setInitialValue("all-TUs") before calling createExecutorFromCommandLineArgs().

[juliehockett]

clang-tools-extra/clang-doc/tool/ClangDocMain.cpp

203 ↗

(On Diff #169304)

Perfect. Thanks!

[ioeric]

clang-tools-extra/clang-doc/tool/ClangDocMain.cpp

89 ↗

(On Diff #169411)

This flag can also be removed. Users can still use --executor to override the default.

clang-doc/tool/ClangDocMain.cpp

 #include "clang/AST/AST.h"
 #include "clang/AST/Decl.h"
 #include "clang/ASTMatchers/ASTMatchFinder.h"
 #include "clang/ASTMatchers/ASTMatchersInternal.h"
 #include "clang/Driver/Options.h"
 #include "clang/Frontend/FrontendActions.h"
 #include "clang/Tooling/CommonOptionsParser.h"
 #include "clang/Tooling/Execution.h"
-#include "clang/Tooling/StandaloneExecution.h"
 #include "clang/Tooling/Tooling.h"
 #include "llvm/ADT/APFloat.h"
 #include "llvm/Support/CommandLine.h"
 #include "llvm/Support/Error.h"
 #include "llvm/Support/FileSystem.h"
 #include "llvm/Support/Path.h"
 #include "llvm/Support/Process.h"
 #include "llvm/Support/Signals.h"
bool bitcodeResultsToInfos(
   });
   return Err;
 }
 
 int main(int argc, const char **argv) {
   llvm::sys::PrintStackTraceOnErrorSignal(argv[0]);
   std::error_code OK;
 
+  ExecutorName.setInitialValue("all-TUs");
   auto Exec = clang::tooling::createExecutorFromCommandLineArgs(
       argc, argv, ClangDocCategory);
 
   if (!Exec) {
     llvm::errs() << toString(Exec.takeError()) << "\n";
     return 1;
   }
 

test/clang-doc/single-file-public.cpp

 // RUN: rm -rf %t
 // RUN: mkdir %t
 // RUN: echo "" > %t/compile_flags.txt
 // RUN: cp "%s" "%t/test.cpp"
-// RUN: clang-doc --doxygen --public -p %t %t/test.cpp -output=%t/docs
+// RUN: clang-doc --doxygen --public --executor=standalone -p %t %t/test.cpp -output=%t/docs
 // RUN: cat %t/docs/Record.yaml | FileCheck %s --check-prefix=CHECK
 // RUN: rm -rf %t
 
 class Record {
 private:
   void function_private();
 
 public:

test/clang-doc/single-file.cpp

 // RUN: rm -rf %t
 // RUN: mkdir %t
 // RUN: echo "" > %t/compile_flags.txt
 // RUN: cp "%s" "%t/test.cpp"
-// RUN: clang-doc --doxygen -p %t %t/test.cpp -output=%t/docs
+// RUN: clang-doc --doxygen --executor=standalone -p %t %t/test.cpp -output=%t/docs
 // RUN: cat %t/docs/GlobalNamespace.yaml | FileCheck %s --check-prefix=CHECK
 // RUN: rm -rf %t
 
 void function(int x);
 
 void function(int x) {}
 
 // CHECK: ---