This is an archive of the discontinued LLVM Phabricator instance.

Differential D53097

[WebAssembly][NFC] Use vnot patfrag to simplify v128.not
ClosedPublic

Authored by tlively on Oct 10 2018, 10:33 AM.

Details

Reviewers
aheejin
dschuff
Commits
rG103f0161b385: [WebAssembly][NFC] Use vnot patfrag to simplify v128.not
rL344175: [WebAssembly][NFC] Use vnot patfrag to simplify v128.not

Diff Detail

Event Timeline

tlively created this revision.Oct 10 2018, 10:33 AM
Herald added subscribers: llvm-commits, sunfish, jgravelle-google, sbc100. · View Herald TranscriptOct 10 2018, 10:33 AM
Harbormaster completed remote builds in B23651: Diff 169044.Oct 10 2018, 10:33 AM
aheejin accepted this revision.Oct 10 2018, 11:34 AM
This revision is now accepted and ready to land.Oct 10 2018, 11:34 AM
Closed by commit rL344175: [WebAssembly][NFC] Use vnot patfrag to simplify v128.not (authored by tlively). · Explain WhyOct 10 2018, 12:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
WebAssembly/
21 lines

Diff 169044

lib/Target/WebAssembly/WebAssemblyInstrSIMD.td

Show First 20 Lines • Show All 502 Lines • ▼ Show 20 Lines
// Bitwise logic: v128.and / v128.or / v128.xor // Bitwise logic: v128.and / v128.or / v128.xor
let isCommutable = 1 in { let isCommutable = 1 in {
defm AND : SIMDBitwise<and, "and", 60>; defm AND : SIMDBitwise<and, "and", 60>;
defm OR : SIMDBitwise<or, "or", 61>; defm OR : SIMDBitwise<or, "or", 61>;
defm XOR : SIMDBitwise<xor, "xor", 62>; defm XOR : SIMDBitwise<xor, "xor", 62>;
} // isCommutable = 1 } // isCommutable = 1
// Bitwise logic: v128.not // Bitwise logic: v128.not
multiclass SIMDNot<ValueType vec_t, PatFrag splat_pat, ValueType lane_t> { multiclass SIMDNot<ValueType vec_t> {
defm NOT_#vec_t : SIMD_I<(outs V128:$dst), (ins V128:$vec), defm NOT_#vec_t : SIMD_I<(outs V128:$dst), (ins V128:$vec), (outs), (ins),
(outs), (ins), [(set (vec_t V128:$dst), (vec_t (vnot V128:$vec)))],
[(set
(vec_t V128:$dst),
(vec_t (xor
(vec_t V128:$vec),
(vec_t (splat_pat (lane_t -1)))
))
)],
"v128.not\t$dst, $vec", "v128.not", 63>; "v128.not\t$dst, $vec", "v128.not", 63>;
} }
defm "" : SIMDNot<v16i8, splat16, i32>; defm "" : SIMDNot<v16i8>;
defm "" : SIMDNot<v8i16, splat8, i32>; defm "" : SIMDNot<v8i16>;
defm "" : SIMDNot<v4i32, splat4, i32>; defm "" : SIMDNot<v4i32>;
defm "" : SIMDNot<v2i64, splat2, i64>; defm "" : SIMDNot<v2i64>;
// Bitwise select: v128.bitselect // Bitwise select: v128.bitselect
def wasm_bitselect_t : SDTypeProfile<1, 3, def wasm_bitselect_t : SDTypeProfile<1, 3,
[SDTCisVec<0>, SDTCisSameAs<0, 1>, SDTCisSameAs<0, 2>, SDTCisSameAs<0, 3>] [SDTCisVec<0>, SDTCisSameAs<0, 1>, SDTCisSameAs<0, 2>, SDTCisSameAs<0, 3>]
>; >;
def wasm_bitselect : SDNode<"WebAssemblyISD::BITSELECT", wasm_bitselect_t>; def wasm_bitselect : SDNode<"WebAssemblyISD::BITSELECT", wasm_bitselect_t>;
multiclass Bitselect<ValueType vec_t> { multiclass Bitselect<ValueType vec_t> {
▲ Show 20 Lines • Show All 268 Lines • Show Last 20 Lines