Page MenuHomePhabricator

[Hexagon] Use GetLinkerPath method instead of hard-coded linker name.
ClosedPublic

Authored by sidneym on Oct 9 2018, 1:21 PM.

Diff Detail

Repository
rC Clang

Event Timeline

sidneym created this revision.Oct 9 2018, 1:21 PM
kparzysz accepted this revision.Oct 9 2018, 1:23 PM
This revision is now accepted and ready to land.Oct 9 2018, 1:23 PM
This revision was automatically updated to reflect the committed changes.

A bisect revealed this change as the source of test failures on my Red Hat Fedora 28 Linux box. How was/is this tested?

Command Output (stderr):

/home/dave/s/lc/tools/clang/test/Driver/linux-ld.c:882:19: error: CHECK-HEXAGON: expected string not found in input
// CHECK-HEXAGON: "{{.*}}hexagon-link{{(.exe)?}}"

^

<stdin>:1:1: note: scanning from here
clang version 8.0.0 (https://git.llvm.org/git/clang.git efe41bf98e6011bb413a5056f0025a4509de860d) (https://git.llvm.org/git/llvm.git 638941f488dd9d1b1b9d49913240fdc2beec56a0)
^
<stdin>:2:3: note: possible intended match here
Target: hexagon-unknown-linux-gnu

^

Testing Time: 43.34s


Failing Tests (2):

  Clang :: Driver/hexagon-toolchain-elf.c
  Clang :: Driver/linux-ld.c

Expected Passes    : 34506
Expected Failures  : 82
Unsupported Tests  : 8838
Unexpected Failures: 2

FAILED: CMakeFiles/check-all

Seems like the test cases do not consider the possibility of CLANG_DEFAULT_LINKER being set. If CLANG_DEFAULT_LINKER was set to "hexagon-link" these tests would probably pass.

I'm checking this out now.