This is an archive of the discontinued LLVM Phabricator instance.

Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables
ClosedPublic

Authored by sylvestre.ledru on Oct 9 2018, 1:21 AM.

Details

Summary

When building clang in stage2, when -DCMAKE_BUILD_TYPE=RelWithDebInfo is set,
the developer can expect that the stage2 clang is built using the same mode.
Especially as the performances are much worst in debug mode.
(Principle of least astonishment)

Diff Detail

Event Timeline

sylvestre.ledru created this revision.Oct 9 2018, 1:21 AM
serge-sans-paille accepted this revision.Jun 9 2021, 1:43 AM

LGTM, sorry for the late review.

This revision is now accepted and ready to land.Jun 9 2021, 1:43 AM

Rebase of the patch

Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2021, 1:44 AM
This revision was landed with ongoing or failed builds.Sep 21 2021, 1:45 AM
This revision was automatically updated to reflect the committed changes.