This is an archive of the discontinued LLVM Phabricator instance.

Differential D53014

Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables
ClosedPublic

Authored by sylvestre.ledru on Oct 9 2018, 1:21 AM.

Details

Reviewers
ecbeckmann
beanz
serge-sans-paille
Commits
rGeccd477ce312: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables
Summary

When building clang in stage2, when -DCMAKE_BUILD_TYPE=RelWithDebInfo is set,
the developer can expect that the stage2 clang is built using the same mode.
Especially as the performances are much worst in debug mode.
(Principle of least astonishment)

Diff Detail

Event Timeline

sylvestre.ledru created this revision.Oct 9 2018, 1:21 AM
Herald added a subscriber: mgorny. · View Herald TranscriptOct 9 2018, 1:21 AM
Harbormaster completed remote builds in B23578: Diff 168755.Oct 9 2018, 1:21 AM
sylvestre.ledru added a reviewer: beanz.Jan 16 2019, 11:50 PM
sylvestre.ledru added a reviewer: serge-sans-paille.Apr 4 2021, 9:24 AM
simon.giesecke added a subscriber: simon.giesecke.May 7 2021, 4:19 AM
serge-sans-paille accepted this revision.Jun 9 2021, 1:43 AM

LGTM, sorry for the late review.

This revision is now accepted and ready to land.Jun 9 2021, 1:43 AM
sylvestre.ledru updated this revision to Diff 373804.Sep 21 2021, 1:44 AM

Rebase of the patch

Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2021, 1:44 AM
This revision was landed with ongoing or failed builds.Sep 21 2021, 1:45 AM
Closed by commit rGeccd477ce312: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables (authored by sylvestre.ledru). · Explain Why
This revision was automatically updated to reflect the committed changes.
sylvestre.ledru added a commit: rGeccd477ce312: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables.
Harbormaster completed remote builds in B124825: Diff 373804.Sep 21 2021, 3:17 AM
CarlosAlbertoEnciso mentioned this in D131755: [CMake] Explicit bootstrap options override any passthrough ones..Aug 12 2022, 2:30 AM
CarlosAlbertoEnciso mentioned this in rG177cbb1c9b66: [CMake] Explicit bootstrap options override any passthrough ones..Aug 17 2022, 12:17 AM

Revision Contents

PathSize
1 line

Diff 168755

CMakeLists.txt

Show First 20 Lines • Show All 603 Lines • ▼ Show 20 Lines set(_BOOTSTRAP_DEFAULT_PASSTHROUGH
CLANG_VERSION_MAJOR CLANG_VERSION_MAJOR
CLANG_VERSION_MINOR CLANG_VERSION_MINOR
CLANG_VERSION_PATCHLEVEL CLANG_VERSION_PATCHLEVEL
LLVM_VERSION_SUFFIX LLVM_VERSION_SUFFIX
LLVM_BINUTILS_INCDIR LLVM_BINUTILS_INCDIR
CLANG_REPOSITORY_STRING CLANG_REPOSITORY_STRING
CMAKE_MAKE_PROGRAM CMAKE_MAKE_PROGRAM
CMAKE_OSX_ARCHITECTURES CMAKE_OSX_ARCHITECTURES
CMAKE_BUILD_TYPE
LLVM_ENABLE_PROJECTS LLVM_ENABLE_PROJECTS
LLVM_ENABLE_RUNTIMES) LLVM_ENABLE_RUNTIMES)
# We don't need to depend on compiler-rt/libcxx if we're building instrumented # We don't need to depend on compiler-rt/libcxx if we're building instrumented
# because the next stage will use the same compiler used to build this stage. # because the next stage will use the same compiler used to build this stage.
if(NOT LLVM_BUILD_INSTRUMENTED) if(NOT LLVM_BUILD_INSTRUMENTED)
if(TARGET compiler-rt) if(TARGET compiler-rt)
add_dependencies(clang-bootstrap-deps compiler-rt) add_dependencies(clang-bootstrap-deps compiler-rt)
▲ Show 20 Lines • Show All 137 Lines • Show Last 20 Lines