Page MenuHomePhabricator

[mips][microMIPS] Implement ADDIUPC instruction
Needs RevisionPublic

Authored by Radovan.Obradovic on Sep 10 2014, 6:47 AM.

Details

Diff Detail

Event Timeline

Radovan.Obradovic retitled this revision from to [mips][microMIPS] Implement ADDIUPC instruction.
Radovan.Obradovic updated this object.
Radovan.Obradovic edited the test plan for this revision. (Show Details)
Radovan.Obradovic added reviewers: dsanders, vmedic.
sstankovic added inline comments.
lib/Target/Mips/AsmParser/MipsAsmParser.cpp
1122

I think you can use "if (Imm % 4 != 0)" instead of a call to OffsetToAlignment.

lib/Target/Mips/Disassembler/MipsDisassembler.cpp
1346

You should add disassembler tests for addiupc.

lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp
667

Comment is wrong - it should be 'immediate >> 2'.

lib/Target/Mips/MicroMipsInstrInfo.td
112

You need rs here instead of rd (ADDIUPC_FM_MM uses rs).

sstankovic removed a subscriber: sstankovic.
jkolek requested changes to this revision.Dec 11 2014, 4:39 AM
jkolek added a reviewer: jkolek.
This revision now requires changes to proceed.Dec 11 2014, 4:39 AM
dsanders resigned from this revision.Feb 4 2016, 2:53 AM
dsanders removed a reviewer: dsanders.

Given that it's been replaced: Resigning as reviewer to prevent it showing up in my phabricator queue.
It should also be marked abandoned in by the author.

Can this be marked abandoned?

Thanks.