This is an archive of the discontinued LLVM Phabricator instance.

Differential D52877

[Index] Respect "IndexFunctionLocals" option for type loc.
ClosedPublic

Authored by hokein on Oct 4 2018, 3:46 AM.

Details

Reviewers
sammccall
Commits
rGe94c86943443: [Index] Respect "IndexFunctionLocals" option for type loc.
rL343767: [Index] Respect "IndexFunctionLocals" option for type loc.
rC343767: [Index] Respect "IndexFunctionLocals" option for type loc.
Summary

Previously, clang index ignored local symbols defined in the function body even
IndexFunctionLocals is true.

Diff Detail

Event Timeline

hokein created this revision.Oct 4 2018, 3:46 AM
Herald added subscribers: kadircet, arphaman, ioeric, ilya-biryukov. · View Herald TranscriptOct 4 2018, 3:46 AM
Harbormaster completed remote builds in B23450: Diff 168261.Oct 4 2018, 3:46 AM
sammccall accepted this revision.Oct 4 2018, 3:52 AM

(can you update the title/summary to reflect that only local *types* are affected?)

This revision is now accepted and ready to land.Oct 4 2018, 3:52 AM
hokein retitled this revision from [Index] Respect "IndexFunctionLocals" option during index. to [Index] Respect "IndexFunctionLocals" option for type loc..Oct 4 2018, 4:02 AM
hokein edited the summary of this revision. (Show Details)
Closed by commit rC343767: [Index] Respect "IndexFunctionLocals" option for type loc. (authored by hokein). · Explain WhyOct 4 2018, 4:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Index/
3 lines
test/
Index/
6 lines

Diff 168261

lib/Index/IndexTypeSourceInfo.cpp

Show First 20 Lines • Show All 94 Lines • ▼ Show 20 Lines#define TRY_TO(CALL_EXPR) \
bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNS) { bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNS) {
IndexCtx.indexNestedNameSpecifierLoc(NNS, Parent, ParentDC); IndexCtx.indexNestedNameSpecifierLoc(NNS, Parent, ParentDC);
return true; return true;
} }
bool VisitTagTypeLoc(TagTypeLoc TL) { bool VisitTagTypeLoc(TagTypeLoc TL) {
TagDecl *D = TL.getDecl(); TagDecl *D = TL.getDecl();
if (D->getParentFunctionOrMethod()) if (!IndexCtx.shouldIndexFunctionLocalSymbols() &&
D->getParentFunctionOrMethod())
return true; return true;
if (TL.isDefinition()) { if (TL.isDefinition()) {
IndexCtx.indexTagDecl(D); IndexCtx.indexTagDecl(D);
return true; return true;
} }
return IndexCtx.handleReference(D, TL.getNameLoc(), return IndexCtx.handleReference(D, TL.getNameLoc(),
▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines

test/Index/index-local-symbol.cpp

  • This file was added.
void ff() {
struct Foo {};
}
// RUN: env CINDEXTEST_INDEXLOCALSYMBOLS=1 c-index-test -index-file %s | FileCheck %s
// CHECK: [indexDeclaration]: kind: struct | name: Foo | {{.*}} | loc: 2:10
No newline at end of file