This is an archive of the discontinued LLVM Phabricator instance.

Differential D52809

[COFF, ARM64] Add _ReadWriteBarrier intrinsic
ClosedPublic

Authored by mgrang on Oct 2 2018, 4:19 PM.

Details

Reviewers
rnk
mstorsjo
compnerd
TomTan
haripul
javed.absar
Commits
rGaef87980a97c: [COFF, ARM64] Add _ReadWriteBarrier intrinsic
rC343699: [COFF, ARM64] Add _ReadWriteBarrier intrinsic
rL343699: [COFF, ARM64] Add _ReadWriteBarrier intrinsic

Diff Detail

Repository
rL LLVM

Event Timeline

mgrang created this revision.Oct 2 2018, 4:19 PM
Herald added a reviewer: javed.absar. · View Herald TranscriptOct 2 2018, 4:19 PM
Herald added subscribers: jfb, chrib, kristof.beyls. · View Herald Transcript
rnk accepted this revision.Oct 2 2018, 4:24 PM

lgtm

This revision is now accepted and ready to land.Oct 2 2018, 4:24 PM
Closed by commit rL343699: [COFF, ARM64] Add _ReadWriteBarrier intrinsic (authored by mgrang). · Explain WhyOct 3 2018, 10:26 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptOct 3 2018, 10:26 AM

Revision Contents

PathSize
cfe/
trunk/
include/
clang/
Basic/
2 lines
lib/
CodeGen/
4 lines
test/
CodeGen/
7 lines

Diff 168131

cfe/trunk/include/clang/Basic/BuiltinsAArch64.def

Show First 20 Lines • Show All 97 Lines • ▼ Show 20 Lines
TARGET_HEADER_BUILTIN(_InterlockedDecrement64, "LLiLLiD*", "nh", "intrin.h", ALL_MS_LANGUAGES, "") TARGET_HEADER_BUILTIN(_InterlockedDecrement64, "LLiLLiD*", "nh", "intrin.h", ALL_MS_LANGUAGES, "")
TARGET_HEADER_BUILTIN(_InterlockedExchange64, "LLiLLiD*LLi", "nh", "intrin.h", ALL_MS_LANGUAGES, "") TARGET_HEADER_BUILTIN(_InterlockedExchange64, "LLiLLiD*LLi", "nh", "intrin.h", ALL_MS_LANGUAGES, "")
TARGET_HEADER_BUILTIN(_InterlockedExchangeAdd64, "LLiLLiD*LLi", "nh", "intrin.h", ALL_MS_LANGUAGES, "") TARGET_HEADER_BUILTIN(_InterlockedExchangeAdd64, "LLiLLiD*LLi", "nh", "intrin.h", ALL_MS_LANGUAGES, "")
TARGET_HEADER_BUILTIN(_InterlockedExchangeSub64, "LLiLLiD*LLi", "nh", "intrin.h", ALL_MS_LANGUAGES, "") TARGET_HEADER_BUILTIN(_InterlockedExchangeSub64, "LLiLLiD*LLi", "nh", "intrin.h", ALL_MS_LANGUAGES, "")
TARGET_HEADER_BUILTIN(_InterlockedIncrement64, "LLiLLiD*", "nh", "intrin.h", ALL_MS_LANGUAGES, "") TARGET_HEADER_BUILTIN(_InterlockedIncrement64, "LLiLLiD*", "nh", "intrin.h", ALL_MS_LANGUAGES, "")
TARGET_HEADER_BUILTIN(_InterlockedOr64, "LLiLLiD*LLi", "nh", "intrin.h", ALL_MS_LANGUAGES, "") TARGET_HEADER_BUILTIN(_InterlockedOr64, "LLiLLiD*LLi", "nh", "intrin.h", ALL_MS_LANGUAGES, "")
TARGET_HEADER_BUILTIN(_InterlockedXor64, "LLiLLiD*LLi", "nh", "intrin.h", ALL_MS_LANGUAGES, "") TARGET_HEADER_BUILTIN(_InterlockedXor64, "LLiLLiD*LLi", "nh", "intrin.h", ALL_MS_LANGUAGES, "")
TARGET_HEADER_BUILTIN(_ReadWriteBarrier, "v", "nh", "intrin.h", ALL_MS_LANGUAGES, "")
#undef BUILTIN #undef BUILTIN
#undef LANGBUILTIN #undef LANGBUILTIN
#undef TARGET_HEADER_BUILTIN #undef TARGET_HEADER_BUILTIN

cfe/trunk/lib/CodeGen/CGBuiltin.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 6,575 Lines • ▼ Show 20 Lines if (BuiltinID == AArch64::BI__builtin_arm_strex ||
return Builder.CreateCall(F, {StoreVal, StoreAddr}, "stxr"); return Builder.CreateCall(F, {StoreVal, StoreAddr}, "stxr");
} }
if (BuiltinID == AArch64::BI__builtin_arm_clrex) { if (BuiltinID == AArch64::BI__builtin_arm_clrex) {
Function *F = CGM.getIntrinsic(Intrinsic::aarch64_clrex); Function *F = CGM.getIntrinsic(Intrinsic::aarch64_clrex);
return Builder.CreateCall(F); return Builder.CreateCall(F);
} }
if (BuiltinID == AArch64::BI_ReadWriteBarrier)
return Builder.CreateFence(llvm::AtomicOrdering::SequentiallyConsistent,
llvm::SyncScope::SingleThread);
// CRC32 // CRC32
Intrinsic::ID CRCIntrinsicID = Intrinsic::not_intrinsic; Intrinsic::ID CRCIntrinsicID = Intrinsic::not_intrinsic;
switch (BuiltinID) { switch (BuiltinID) {
case AArch64::BI__builtin_arm_crc32b: case AArch64::BI__builtin_arm_crc32b:
CRCIntrinsicID = Intrinsic::aarch64_crc32b; break; CRCIntrinsicID = Intrinsic::aarch64_crc32b; break;
case AArch64::BI__builtin_arm_crc32cb: case AArch64::BI__builtin_arm_crc32cb:
CRCIntrinsicID = Intrinsic::aarch64_crc32cb; break; CRCIntrinsicID = Intrinsic::aarch64_crc32cb; break;
case AArch64::BI__builtin_arm_crc32h: case AArch64::BI__builtin_arm_crc32h:
▲ Show 20 Lines • Show All 6,039 Lines • Show Last 20 Lines

cfe/trunk/test/CodeGen/arm64-microsoft-intrinsics.c

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines
// CHECK-LINUX: error: implicit declaration of function '__sev' // CHECK-LINUX: error: implicit declaration of function '__sev'
void check__sevl(void) { void check__sevl(void) {
__sevl(); __sevl();
} }
// CHECK-MSVC: @llvm.aarch64.hint(i32 5) // CHECK-MSVC: @llvm.aarch64.hint(i32 5)
// CHECK-LINUX: error: implicit declaration of function '__sevl' // CHECK-LINUX: error: implicit declaration of function '__sevl'
void check_ReadWriteBarrier() {
_ReadWriteBarrier();
}
// CHECK-MSVC: fence syncscope("singlethread")
// CHECK-LINUX: error: implicit declaration of function '_ReadWriteBarrier'