This is an archive of the discontinued LLVM Phabricator instance.

[cl-compat] Change /JMC from unsupported to ignored.
ClosedPublic

Authored by zturner on Oct 2 2018, 1:14 PM.

Details

Summary

This command line option doesn't really affect generated code, only generated debug info, and it's set by default in newer versions of VS, so it's annoying to have to turn it off in order to be able to use the VS Integration extension.

Diff Detail

Repository
rL LLVM

Event Timeline

zturner created this revision.Oct 2 2018, 1:14 PM
rnk added a comment.Oct 2 2018, 1:23 PM

lgtm Can you file a bug about implementing /JMC and link it from the commit message?

This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2018, 1:44 PM
This revision was automatically updated to reflect the committed changes.
hans added a subscriber: hans.Oct 3 2018, 2:21 AM

Thanks for fixing! Please also update the test in test/Driver/cl-options.c and include me on clang-cl code reviews.