This is an archive of the discontinued LLVM Phabricator instance.

Reorder FindPythonInterp so that config-ix can use PYTHON_EXECUTABLE
ClosedPublic

Authored by lanza on Oct 1 2018, 7:22 PM.

Details

Summary

Code in config-ix tries to call PYTHON_EXECUTABLE to search for some
python modules but that variable isn't set until the moved chunk of
code that finds Python is called.

Reorder it so CMake can use PYTHON_EXECUTABLE

Diff Detail

Event Timeline

lanza created this revision.Oct 1 2018, 7:22 PM
rnk edited reviewers, added: zturner; removed: rnk.Nov 7 2018, 1:07 PM
rnk accepted this revision.Nov 7 2018, 1:10 PM
rnk added a subscriber: rnk.

I was going to consult @zturner about the state of Python 3 in LLDB, but that's not really related to your change. I think it's fine. lgtm

This revision is now accepted and ready to land.Nov 7 2018, 1:10 PM
lanza added a comment.Nov 7 2018, 2:51 PM

Yea, unrelated to python3. Just a trivial fix to stop the cannot find pygments in the cmake invocation due to not having PYTHON_EXECUTABLE defined at that point.

This revision was automatically updated to reflect the committed changes.