This is an archive of the discontinued LLVM Phabricator instance.

Differential D52746

[clang-query] Add single-letter 'q' alias for 'quit'
ClosedPublic

Authored by steveire on Oct 1 2018, 1:50 PM.

Details

Reviewers
aaron.ballman
pcc
Commits
rG42668a4d032f: [clang-query] Add single-letter 'q' alias for 'quit'
rL343664: [clang-query] Add single-letter 'q' alias for 'quit'
rCTE343664: [clang-query] Add single-letter 'q' alias for 'quit'

Diff Detail

Event Timeline

steveire created this revision.Oct 1 2018, 1:50 PM
Herald added a subscriber: cfe-commits. · View Herald TranscriptOct 1 2018, 1:50 PM
Harbormaster completed remote builds in B23317: Diff 167822.Oct 1 2018, 1:50 PM
steveire updated this revision to Diff 167825.Oct 1 2018, 1:57 PM

Add test

Harbormaster completed remote builds in B23319: Diff 167825.Oct 1 2018, 1:57 PM
steveire edited reviewers, added: pcc; removed: alexfh.Oct 1 2018, 2:49 PM
Szelethus added a subscriber: Szelethus.EditedOct 1 2018, 2:50 PM

I'd really enjoy this feature.

steveire added a comment.Oct 2 2018, 6:43 AM

@Szelethus You can approve it and then you will get the feature :).

aaron.ballman added a comment.Oct 2 2018, 6:49 AM

Please update HelpQuery::run() to print out the new mnemonic (it's the *only* form of public documentation we have for clang-query currently).

steveire updated this revision to Diff 167984.Oct 2 2018, 11:08 AM

Add docs

Harbormaster completed remote builds in B23370: Diff 167984.Oct 2 2018, 11:08 AM
steveire added a comment.Oct 2 2018, 11:09 AM
In D52746#1252455, @aaron.ballman wrote:

Please update HelpQuery::run() to print out the new mnemonic (it's the *only* form of public documentation we have for clang-query currently).

Good point, thanks!

aaron.ballman accepted this revision.Oct 2 2018, 2:38 PM

LGTM!

This revision is now accepted and ready to land.Oct 2 2018, 2:38 PM
Closed by commit rCTE343664: [clang-query] Add single-letter 'q' alias for 'quit' (authored by steveire). · Explain WhyOct 3 2018, 12:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang-query/
1 line

Diff 167822

clang-query/QueryParser.cpp

Show First 20 Lines • Show All 160 Lines • ▼ Show 20 LinesQueryRef QueryParser::doParse() {
StringRef CommandStr; StringRef CommandStr;
ParsedQueryKind QKind = LexOrCompleteWord<ParsedQueryKind>(this, CommandStr) ParsedQueryKind QKind = LexOrCompleteWord<ParsedQueryKind>(this, CommandStr)
.Case("", PQK_NoOp) .Case("", PQK_NoOp)
.Case("help", PQK_Help) .Case("help", PQK_Help)
.Case("l", PQK_Let, /*IsCompletion=*/false) .Case("l", PQK_Let, /*IsCompletion=*/false)
.Case("let", PQK_Let) .Case("let", PQK_Let)
.Case("m", PQK_Match, /*IsCompletion=*/false) .Case("m", PQK_Match, /*IsCompletion=*/false)
.Case("match", PQK_Match) .Case("match", PQK_Match)
.Case("q", PQK_Quit, /*IsCompletion=*/false)
.Case("quit", PQK_Quit) .Case("quit", PQK_Quit)
.Case("set", PQK_Set) .Case("set", PQK_Set)
.Case("unlet", PQK_Unlet) .Case("unlet", PQK_Unlet)
.Default(PQK_Invalid); .Default(PQK_Invalid);
switch (QKind) { switch (QKind) {
case PQK_NoOp: case PQK_NoOp:
return new NoOpQuery; return new NoOpQuery;
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines