Page MenuHomePhabricator

[analyzer] Move StdCLibraryFunctions to apiModeling
ClosedPublic

Authored by donat.nagy on Oct 1 2018, 5:45 AM.

Details

Summary

StdCLibraryFunctionsChecker models the evaluation of several well-known
functions of the C standard library. This commit moves it to the
apiModeling category, which is loaded by default (it was in the unix
category, despite the fact that it models platform-independent standard
functions). As we load this checker, ConversionChecker will no longer
emit false positives when it encunters certain functions (e.g. getc()
and the character classification functions); this commit updates its
regression test to reflect this fact.

Diff Detail

Repository
rL LLVM

Event Timeline

donat.nagy created this revision.Oct 1 2018, 5:45 AM
NoQ accepted this revision.Oct 1 2018, 12:02 PM

Aha, ok, apiModeling is on by default, like core. Cool, thanks!

This revision is now accepted and ready to land.Oct 1 2018, 12:02 PM

I don't have commit rights, please commit for me @NoQ or @martong

This revision was automatically updated to reflect the committed changes.