This is an archive of the discontinued LLVM Phabricator instance.

Move llvm util dependencies from clang-tools-extra to add_lit_target.
ClosedPublic

Authored by hokein on Oct 1 2018, 3:15 AM.

Diff Detail

Event Timeline

hokein created this revision.Oct 1 2018, 3:15 AM
sammccall accepted this revision.Oct 1 2018, 6:02 AM

(again I'd just inline this into three add_dependencies calls, but up to you)

This revision is now accepted and ready to land.Oct 1 2018, 6:02 AM

inlining this into three add_dependencies calls would remove the if (TARGET) conditions. Are those dependencies conditionally built?

hokein added a comment.Oct 1 2018, 6:45 AM

inlining this into three add_dependencies calls would remove the if (TARGET) conditions. Are those dependencies conditionally built?

Yeah, I believe these targets are built conditionally, see https://reviews.llvm.org/D29851.

This revision was automatically updated to reflect the committed changes.

I would like to request reverting this. It's established standard within LLVM to explicitly specify the dependencies the particular test suite relies on.

This change causes the -DLLVM_OCAML_OUT_OF_TREE=1 to start wrongly depending on additional test utility targets, causing building an unnecessary second copy of LLVMSupport.

hokein added a subscriber: chapuni.Nov 21 2018, 5:33 AM

Hi @mgorny, sorry for the trouble it might cause.

I would like to request reverting this. It's established standard within LLVM to explicitly specify the dependencies the particular test suite relies on.
This change causes the -DLLVM_OCAML_OUT_OF_TREE=1 to start wrongly depending on additional test utility targets, causing building an unnecessary second copy of LLVMSupport.

I'm not an expert on this. It seems to me that FileCheck, count, not are reasonable dependencies to lit tests, and from what I se, lit tests of llvm, clang and clang-tools-extra are using these dep tools.
+ @chapuni, maybe you have ideas here? since you are the original author of the code r301762.

This particular build method uses system-wide installation of these tools.

This particular build method uses system-wide installation of these tools.

Sounds fair enough. I sent you two patches to move this back to clang-tools-extra.