[clang-tidy] NFC use CHECK-NOTES in tests for misc-misplaced-const

[alexfh]

test/clang-tidy/misc-misplaced-const.c

18

These notes are also just marginally useful and make it harder to change the test. I wonder whether an absolute line number would make more sense here. Or maybe just add a test for one of the notes and leave out the rest (and keep CHECK-MESSAGES)?

[JonasToth]

test/clang-tidy/misc-misplaced-const.c

18

Absolute line number makes sense. IMHO the tests should cover all generated diagnostics including the notes. Would you accept sticking with CHECK-NOTES but with absolute line numbers?

[alexfh]

test/clang-tidy/misc-misplaced-const.c

18

IMHO the tests should cover all generated diagnostics including the notes.

I wouldn't call this the most important goal. I'd say that tests should cover important aspects of the output, not every single character of it. Another useful feature is that tests should be easy to create, read, and change. In cases like this - where the benefit of the change is not obvious - I would leave the decision to the author of the check.

Aaron, WDYT?

[JonasToth]

• use absolute line number for note

[JonasToth]

test/clang-tidy/misc-misplaced-const.c

18

@aaron.ballman not sure if you overlooked that note

[JonasToth]

ping :)

[JonasToth]

not so relevant and spams my view

test/clang-tidy/misc-misplaced-const.c

 // RUN: %check_clang_tidy %s misc-misplaced-const %t
 
 typedef int plain_i;
 typedef int *ip;
 typedef const int *cip;
 
 typedef void (*func_ptr)(void);
 
 void func(void) {
   // ok
   const int *i0 = 0;
   const plain_i *i1 = 0;
   const cip i2 = 0; // const applies to both pointer and pointee.
 
   // Not ok
   const ip i3 = 0;
-  // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: 'i3' declared with a const-qualified typedef type; results in the type being 'int *const' instead of 'const int *'
+  // CHECK-NOTES: :[[@LINE-1]]:12: warning: 'i3' declared with a const-qualified typedef type; results in the type being 'int *const' instead of 'const int *'
+  // CHECK-NOTES: :4:14: note: typedef declared here
 
   ip const i4 = 0;
-  // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: 'i4' declared with a const-qualified
+  // CHECK-NOTES: :[[@LINE-1]]:12: warning: 'i4' declared with a const-qualified
+  // CHECK-NOTES: :4:14: note: typedef declared here
 
   const volatile ip i5 = 0;
-  // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: 'i5' declared with a const-qualified typedef type; results in the type being 'int *const volatile' instead of 'const int *volatile'
+  // CHECK-NOTES: :[[@LINE-1]]:21: warning: 'i5' declared with a const-qualified typedef type; results in the type being 'int *const volatile' instead of 'const int *volatile'
+  // CHECK-NOTES: :4:14: note: typedef declared here
 }
 
 void func2(const plain_i *i1,
            const cip i2,
            const ip i3,
-           // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: 'i3' declared with a const-qualified
+           // CHECK-NOTES: :[[@LINE-1]]:21: warning: 'i3' declared with a const-qualified
+           // CHECK-NOTES: :4:14: note: typedef declared here
            const int *i4) {
 }
 
 struct S {
   const int *i0;
   const plain_i *i1;
   const cip i2;
   const ip i3;
-  // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: 'i3' declared with a const-qualified
+  // CHECK-NOTES: :[[@LINE-1]]:12: warning: 'i3' declared with a const-qualified
+  // CHECK-NOTES: :4:14: note: typedef declared here
 };
 
 // Function pointers should not be diagnosed because a function
 // pointer type can never be const.
 void func3(const func_ptr fp) {
   const func_ptr fp2 = fp;
 }

test/clang-tidy/misc-misplaced-const.cpp

 // RUN: %check_clang_tidy %s misc-misplaced-const %t
 
 typedef int plain_i;
 typedef int *ip;
 typedef const int *cip;
 
 void func() {
   if (const int *i = 0)
     ;
   if (const plain_i *i = 0)
     ;
   if (const cip i = 0)
     ;
 
-  // CHECK-MESSAGES: :[[@LINE+1]]:16: warning: 'i' declared with a const-qualified typedef type; results in the type being 'int *const' instead of 'const int *'
+  // CHECK-NOTES: :[[@LINE+2]]:16: warning: 'i' declared with a const-qualified typedef type; results in the type being 'int *const' instead of 'const int *'
+  // CHECK-NOTES: :4:14: note: typedef declared here
   if (const ip i = 0)
     ;
 }
 
 template <typename Ty>
 struct S {
   const Ty *i;
   const Ty &i2;