This is an archive of the discontinued LLVM Phabricator instance.

Differential D52688

[clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments
ClosedPublic

Authored by JonasToth on Sep 29 2018, 7:17 AM.

Details

Reviewers
alexfh
aaron.ballman
hokein
Commits
rGee2fcdf5b75b: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments
rL343792: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments
rCTE343792: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments

Diff Detail

Event Timeline

JonasToth created this revision.Sep 29 2018, 7:17 AM
Herald added subscribers: cfe-commits, xazax.hun. · View Herald TranscriptSep 29 2018, 7:17 AM
Harbormaster completed remote builds in B23275: Diff 167601.Sep 29 2018, 7:17 AM
JonasToth updated this revision to Diff 168092.Oct 3 2018, 3:28 AM
  • remove FIX-IT as these will be filtered with the other patch
Harbormaster completed remote builds in B23398: Diff 168092.Oct 3 2018, 3:30 AM
alexfh accepted this revision.Oct 4 2018, 7:56 AM

LG

This revision is now accepted and ready to land.Oct 4 2018, 7:56 AM
Closed by commit rCTE343792: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments (authored by JonasToth). · Explain WhyOct 4 2018, 9:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
clang-tidy/
33 lines

Diff 167601

test/clang-tidy/fuchsia-default-arguments.cpp

// RUN: %check_clang_tidy %s fuchsia-default-arguments %t // RUN: %check_clang_tidy %s fuchsia-default-arguments %t
int foo(int value = 5) { return value; } int foo(int value = 5) { return value; }
// CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-2]]:18: note: FIX-IT applied suggested code changes
// CHECK-FIXES: int foo(int value) { return value; } // CHECK-FIXES: int foo(int value) { return value; }
int f() { int f() {
foo(); foo();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] // CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NEXT: note: default parameter was declared here: // CHECK-NOTES: [[@LINE-8]]:9: note: default parameter was declared here
// CHECK-NEXT: int foo(int value = 5) { return value; }
} }
int bar(int value) { return value; } int bar(int value) { return value; }
int n() { int n() {
foo(0); foo(0);
bar(0); bar(0);
} }
class Baz { class Baz {
public: public:
int a(int value = 5) { return value; } int a(int value = 5) { return value; }
// CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-2]]:18: note: FIX-IT applied suggested code changes
// CHECK-FIXES: int a(int value) { return value; } // CHECK-FIXES: int a(int value) { return value; }
int b(int value) { return value; } int b(int value) { return value; }
}; };
class Foo { class Foo {
// Fix should be suggested in declaration // Fix should be suggested in declaration
int a(int value = 53); int a(int value = 53);
// CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-2]]:18: note: FIX-IT applied suggested code changes
// CHECK-FIXES: int a(int value); // CHECK-FIXES: int a(int value);
}; };
// Fix shouldn't be suggested in implementation // Fix shouldn't be suggested in implementation
int Foo::a(int value) { int Foo::a(int value) {
return value; return value;
} }
// Elided functions // Elided functions
void f(int = 5) {}; void f(int = 5) {};
// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-2]]:11: note: FIX-IT applied suggested code changes
// CHECK-FIXES: void f(int) {}; // CHECK-FIXES: void f(int) {};
void g(int) {}; void g(int) {};
// Should not suggest fix for macro-defined parameters // Should not suggest fix for macro-defined parameters
#define D(val) = val #define D(val) = val
void h(int i D(5)); void h(int i D(5));
// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-FIXES-NOT: void h(int i); // CHECK-FIXES-NOT: void h(int i);
void x(int i); void x(int i);
void x(int i = 12); void x(int i = 12);
// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-2]]:13: note: FIX-IT applied suggested code changes
// CHECK-FIXES: void x(int i); // CHECK-FIXES: void x(int i);
void x(int i) {} void x(int i) {}
struct S { struct S {
void x(int i); void x(int i);
}; };
void S::x(int i = 12) {} void S::x(int i = 12) {}
// CHECK-MESSAGES: [[@LINE-1]]:11: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-NOTES: [[@LINE-1]]:11: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-2]]:16: note: FIX-IT applied suggested code changes
// CHECK-FIXES: void S::x(int i) {} // CHECK-FIXES: void S::x(int i) {}
int main() { int main() {
S s; S s;
s.x(); s.x();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] // CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NEXT: note: default parameter was declared here: // CHECK-NOTES: [[@LINE-9]]:11: note: default parameter was declared here
// CHECK-NEXT: void S::x(int i = 12) {} // CHECK-NEXT: void S::x(int i = 12) {}
x(); x();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] // CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NEXT: note: default parameter was declared here: // CHECK-NOTES: [[@LINE-19]]:8: note: default parameter was declared here
// CHECK-NEXT: void x(int i = 12); // CHECK-NEXT: void x(int i = 12);
} }