Device Libraries has removed irif.amdgcn.bc, so we need to remove this requirement from HIP Toolchains. Also a few header functions need to be updated. Since fence was previously included in irif, we need to move them into hip.amdgcn.bc instead.
Details
Details
Diff Detail
Diff Detail
- Repository
- rC Clang
Event Timeline
Comment Actions
If you don't mind, can you please do another revision with full context (-U99999), makes it easier to review and makes it less likely that svn patch screws up.
Comment Actions
this seems to be duplicate of https://reviews.llvm.org/D51857
Is HIP github ready for this change?
Comment Actions
Added diff with full context. Also, I need to find replacements for few functions in HIP github before this can be submitted.
Comment Actions
I've added a hip.amdgcn.bc library for the fence functions that were originally in irif library.
Comment Actions
The device libraries has been updated, and the hip.amdgcn.bc library is now available there.
lib/Driver/ToolChains/HIP.cpp | ||
---|---|---|
85 | maybe we should put hip.amdgcn.bc at the beginning. In the future, it may depend on other bc's. |
maybe we should put hip.amdgcn.bc at the beginning. In the future, it may depend on other bc's.