[HIP] Remove disabled irif library

Authored by ashi1 on Fri, Sep 28, 2:17 PM.



Device Libraries has removed irif.amdgcn.bc, so we need to remove this requirement from HIP Toolchains. Also a few header functions need to be updated. Since fence was previously included in irif, we need to move them into hip.amdgcn.bc instead.

Diff Detail

ashi1 created this revision.Fri, Sep 28, 2:17 PM

If you don't mind, can you please do another revision with full context (-U99999), makes it easier to review and makes it less likely that svn patch screws up.

yaxunl added a comment.Mon, Oct 1, 7:31 AM

this seems to be duplicate of https://reviews.llvm.org/D51857

Is HIP github ready for this change?

ashi1 updated this revision to Diff 167741.Mon, Oct 1, 7:54 AM

Added diff with full context. Also, I need to find replacements for few functions in HIP github before this can be submitted.

ashi1 updated this revision to Diff 168384.Thu, Oct 4, 2:41 PM
ashi1 edited the summary of this revision. (Show Details)
ashi1 added a comment.Thu, Oct 4, 2:42 PM

I've added a hip.amdgcn.bc library for the fence functions that were originally in irif library.

ashi1 updated this revision to Diff 168836.Tue, Oct 9, 11:07 AM

The device libraries has been updated, and the hip.amdgcn.bc library is now available there.

yaxunl added inline comments.Tue, Oct 9, 11:19 AM
85 ↗(On Diff #168836)

maybe we should put hip.amdgcn.bc at the beginning. In the future, it may depend on other bc's.

ashi1 updated this revision to Diff 168855.Tue, Oct 9, 12:07 PM
ashi1 marked an inline comment as done.

I've moved the hip.amdgcn.bc to the top of the libs. Updated test as well.

yaxunl accepted this revision.Wed, Oct 10, 7:28 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Wed, Oct 10, 7:28 PM
Closed by commit rL344285: [HIP] Remove unused irif bitcode from test (authored by aaronenyeshi, committed by ). · Explain WhyThu, Oct 11, 12:54 PM
This revision was automatically updated to reflect the committed changes.