Download Raw Diff

Details

Reviewers

yaxunl
b-sumner
scchan

Commits

rG72c0373d9a8d: [HIP] Remove unused irif bitcode from test
rC344285: [HIP] Remove unused irif bitcode from test
rL344285: [HIP] Remove unused irif bitcode from test

Summary

Device Libraries has removed irif.amdgcn.bc, so we need to remove this requirement from HIP Toolchains. Also a few header functions need to be updated. Since fence was previously included in irif, we need to move them into hip.amdgcn.bc instead.

Diff Detail

Repository: rL LLVM

Event Timeline

ashi1 created this revision.Sep 28 2018, 2:17 PM

Herald added a subscriber: cfe-commits. · View Herald TranscriptSep 28 2018, 2:17 PM

If you don't mind, can you please do another revision with full context (-U99999), makes it easier to review and makes it less likely that svn patch screws up.

this seems to be duplicate of https://reviews.llvm.org/D51857

Is HIP github ready for this change?

Added diff with full context. Also, I need to find replacements for few functions in HIP github before this can be submitted.

ashi1 updated this revision to Diff 168384.Oct 4 2018, 2:41 PM

ashi1 edited the summary of this revision. (Show Details)

Herald added a subscriber: jfb. · View Herald TranscriptOct 4 2018, 2:41 PM

I've added a hip.amdgcn.bc library for the fence functions that were originally in irif library.

The device libraries has been updated, and the hip.amdgcn.bc library is now available there.

yaxunl added inline comments.Oct 9 2018, 11:19 AM