Tests by @spatel, thanks
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
lib/CodeGen/SelectionDAG/DAGCombiner.cpp | ||
---|---|---|
3133 ↗ | (On Diff #167534) | There should be a TODO comment on the zext line because we don't handle that pattern here. |
test/CodeGen/X86/combine-urem.ll | ||
388 ↗ | (On Diff #167534) | This test should use 'urem' not 'srem'. |
xbolva00@xbolva00:~/LLVM/llvm/utils$ ./update_llc_test_checks.py /home/xbolva00/LLVM/llvm/test/CodeGen/Mips/llvm-ir/urem.ll
Cannot find a triple. Assume 'x86'
Cannot find a triple. Assume 'x86'
Cannot find a triple. Assume 'x86'
and then test crashes :(
/home/xbolva00/LLVM/llvm/test/CodeGen/Mips/llvm-ir/srem.ll:439:16: error: NOT-R6-NEXT: expected string not found in input
; NOT-R6-NEXT: daddiu $sp, $sp, -16
You need to replace -march with -mtriple in RUN statements before running the update_llc_test_checks.py. For example, -march=mips becomes -mtriple=mips.
Thanks, one more problem:
Are you using update_llc_test_checks.py ? The "non-opt" remark makes me think you've used update_test_checks.py
Uh, I messed up. But still some warnings:
LLVM/llvm/test/CodeGen/Mips/llvm-ir/urem.ll
LLVM/llvm/test/CodeGen/Mips/llvm-ir/udiv.ll
test/CodeGen/Mips/llvm-ir/urem.ll | ||
---|---|---|
40–43 ↗ | (On Diff #167624) | All of this non-code output suggests that:
If you do want to auto-gen the checks for this file, that should be done before this patch in a NFC commit. |
test/CodeGen/X86/pr38539.ll | ||
---|---|---|
5 ↗ | (On Diff #167956) | These reduced tests need to be regenerated from the source in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8882 |
test/CodeGen/X86/pr38539.ll | ||
---|---|---|
5 ↗ | (On Diff #167956) |
I reverted D50656 fix for pr38539 and pr38539.ll passed fine. So pr38539.ll tests nothing in the current trunk and it should not block this patch.
Failing Tests (1):
LLVM :: CodeGen/X86/flags-copy-lowering.mir Expected Passes : 11546 Expected Failures : 53 Unsupported Tests : 229 Unexpected Failures: 1