This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Refactor use of signatures
ClosedPublic

Authored by dschuff on Sep 27 2018, 12:07 PM.

Event Timeline

dschuff created this revision.Sep 27 2018, 12:07 PM
dschuff edited the summary of this revision. (Show Details)Sep 27 2018, 12:07 PM
sbc100 accepted this revision.Sep 27 2018, 12:54 PM

LGTM with nits

wasm/WriterUtils.cpp
78

Why not instead change the param type of valueTypeToString?

84

I think the style guide doesn't like auto unless the type is completely obvious (normally if its written on the RHS on the same line in a cast or similar).

119–120

Probably worth updating the type of WasmGlobalType.Type .. maybe add a TODO here saying this cast should probably not be needed in the future?

This revision is now accepted and ready to land.Sep 27 2018, 12:54 PM
dschuff updated this revision to Diff 167415.Sep 27 2018, 4:48 PM
dschuff marked 3 inline comments as done.
  • Comments
This revision was automatically updated to reflect the committed changes.
This comment was removed by xbolva00.