This is an archive of the discontinued LLVM Phabricator instance.

Differential D52619

Fix greedy FileCheck expression in test/Driver/mips-abi.c
ClosedPublic

Authored by Hahnfeld on Sep 27 2018, 9:31 AM.

Details

Reviewers
atanasyan
rnk
Commits
rGfb8ca8a1ec54: Fix greedy FileCheck expression in test/Driver/mips-abi.c
rC343240: Fix greedy FileCheck expression in test/Driver/mips-abi.c
rL343240: Fix greedy FileCheck expression in test/Driver/mips-abi.c
Summary

ld{{.*}}" seems to match the complete line for me which is failing
the test. Only allow an optional .exe for Windows systems as most
other tests do.
Another possibility would be to collapse the greedy expression with
the next check to avoid matching the full line.

Diff Detail

Repository
rL LLVM

Event Timeline

Hahnfeld created this revision.Sep 27 2018, 9:31 AM
Herald added subscribers: cfe-commits, jrtc27, arichardson, sdardis. · View Herald TranscriptSep 27 2018, 9:31 AM
atanasyan accepted this revision.Sep 27 2018, 10:21 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Sep 27 2018, 10:21 AM
Closed by commit rL343240: Fix greedy FileCheck expression in test/Driver/mips-abi.c (authored by Hahnfeld). · Explain WhySep 27 2018, 10:29 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 27 2018, 10:29 AM

Revision Contents

PathSize
cfe/
trunk/
test/
Driver/
6 lines

Diff 167350

cfe/trunk/test/Driver/mips-abi.c

Show First 20 Lines • Show All 163 Lines • ▼ Show 20 Lines
// MIPS-ARCH-UNKNOWN: error: unknown target CPU 'unknown' // MIPS-ARCH-UNKNOWN: error: unknown target CPU 'unknown'
// Check adjusting of target triple accordingly to `-mabi` option. // Check adjusting of target triple accordingly to `-mabi` option.
// RUN: %clang -target mips64-linux-gnu -mabi=32 -### %s 2>&1 \ // RUN: %clang -target mips64-linux-gnu -mabi=32 -### %s 2>&1 \
// RUN: | FileCheck -check-prefix=TARGET-O32 %s // RUN: | FileCheck -check-prefix=TARGET-O32 %s
// TARGET-O32: "-triple" "mips-unknown-linux-gnu" // TARGET-O32: "-triple" "mips-unknown-linux-gnu"
// TARGET-O32: "-target-cpu" "mips32r2" // TARGET-O32: "-target-cpu" "mips32r2"
// TARGET-O32: "-target-abi" "o32" // TARGET-O32: "-target-abi" "o32"
// TARGET-O32: ld{{.*}}" // TARGET-O32: ld{{(.exe)?}}"
// TARGET-O32: "-m" "elf32btsmip" // TARGET-O32: "-m" "elf32btsmip"
// RUN: %clang -target mips-linux-gnu -mabi=n32 -### %s 2>&1 \ // RUN: %clang -target mips-linux-gnu -mabi=n32 -### %s 2>&1 \
// RUN: | FileCheck -check-prefix=TARGET-N32 %s // RUN: | FileCheck -check-prefix=TARGET-N32 %s
// TARGET-N32: "-triple" "mips64-unknown-linux-gnu" // TARGET-N32: "-triple" "mips64-unknown-linux-gnu"
// TARGET-N32: "-target-cpu" "mips64r2" // TARGET-N32: "-target-cpu" "mips64r2"
// TARGET-N32: "-target-abi" "n32" // TARGET-N32: "-target-abi" "n32"
// TARGET-N32: ld{{.*}}" // TARGET-N32: ld{{(.exe)?}}"
// TARGET-N32: "-m" "elf32btsmipn32" // TARGET-N32: "-m" "elf32btsmipn32"
// RUN: %clang -target mips-linux-gnu -mabi=64 -### %s 2>&1 \ // RUN: %clang -target mips-linux-gnu -mabi=64 -### %s 2>&1 \
// RUN: | FileCheck -check-prefix=TARGET-N64 %s // RUN: | FileCheck -check-prefix=TARGET-N64 %s
// TARGET-N64: "-triple" "mips64-unknown-linux-gnu" // TARGET-N64: "-triple" "mips64-unknown-linux-gnu"
// TARGET-N64: "-target-cpu" "mips64r2" // TARGET-N64: "-target-cpu" "mips64r2"
// TARGET-N64: "-target-abi" "n64" // TARGET-N64: "-target-abi" "n64"
// TARGET-N64: ld{{.*}}" // TARGET-N64: ld{{(.exe)?}}"
// TARGET-N64: "-m" "elf64btsmip" // TARGET-N64: "-m" "elf64btsmip"