This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Consolidate SMRD TableGen patterns
ClosedPublic

Authored by tstellar on Sep 26 2018, 9:20 AM.

Details

Summary

Merge the SMRD patterns for CI into the same multiclass as the
patterns for other sub-targets.

This removes some duplicate code and will make it easier for some
future GlobalISel changes I would like to do.

Diff Detail

Event Timeline

tstellar created this revision.Sep 26 2018, 9:20 AM
nhaehnle accepted this revision.Oct 5 2018, 6:11 AM

Nice. Patch LGTM except for one cosmetic issue. No need to update on Phabricator before commit as far as I'm concerned.

lib/Target/AMDGPU/SMInstructions.td
749–750

This patch removes the only place where SM_LOAD_PATTERN.AddedComplexity is used, so the comment should be removed, and the defm name should be removed as well to keep things consistent.

This revision is now accepted and ready to land.Oct 5 2018, 6:11 AM
This revision was automatically updated to reflect the committed changes.