This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Extract mapper logic from clangd-indexer into a library.
ClosedPublic

Authored by sammccall on Sep 25 2018, 6:43 AM.

Event Timeline

sammccall created this revision.Sep 25 2018, 6:43 AM
kadircet accepted this revision.Sep 25 2018, 9:49 AM

LGTM, thanks for factoring out this to a library.

clangd/index/IndexAction.cpp
42

s/Igoring/Ignoring/

64

nit: this is false by default.

clangd/index/IndexAction.h
25

s/ane/are/

What is RefsCallback?

This revision is now accepted and ready to land.Sep 25 2018, 9:49 AM
sammccall marked 3 inline comments as done.Sep 25 2018, 11:38 AM

Thanks!
Will land in a day or two, we maintain some out-of-tree mapreduce patches to this file that I need to turn into a real fork.

clangd/index/IndexAction.h
25

Oops, I considered adding refs collection in this patch and then decided against it (add later instead)

sammccall marked an inline comment as done.

Rebase and address comments.

Leave functionality of clangd-indexer unchanged, to make this easier to land.

On second thoughts, let's just leave the MR functionality in place for now so this can be landed.
Then the out-of-tree stuff can migrate to the library, and we can rip out the MR stuff soon.

This revision was automatically updated to reflect the committed changes.