This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] use CHECK-NOTES in bugprone-unused-return-value
ClosedPublic

Authored by JonasToth on Sep 17 2018, 12:42 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

JonasToth created this revision.Sep 17 2018, 12:42 PM
alexfh accepted this revision.Sep 18 2018, 2:23 AM

LG with a comment.

test/clang-tidy/bugprone-unused-return-value.cpp
81 ↗(On Diff #165808)

I'd probably cut repeated parts of the pattern (starting from the second one) to make them fit 80 characters, e.g. like this:

// CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used

Same for the notes.

This revision is now accepted and ready to land.Sep 18 2018, 2:23 AM
JonasToth updated this revision to Diff 165926.Sep 18 2018, 3:42 AM
  • shorten warning checks
JonasToth marked an inline comment as done.Sep 18 2018, 3:44 AM
This revision was automatically updated to reflect the committed changes.