This is an archive of the discontinued LLVM Phabricator instance.

Differential D52187

[clang-tidy] use CHECK-NOTES in bugprone-unused-return-value
ClosedPublic

Authored by JonasToth on Sep 17 2018, 12:42 PM.

Details

Reviewers
aaron.ballman
alexfh
hokein
Commits
rG5a851f313255: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value
rCTE342468: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value
rL342468: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value

Diff Detail

Repository
rL LLVM

Event Timeline

JonasToth created this revision.Sep 17 2018, 12:42 PM
Herald added subscribers: cfe-commits, xazax.hun. · View Herald TranscriptSep 17 2018, 12:42 PM
alexfh accepted this revision.Sep 18 2018, 2:23 AM

LG with a comment.

test/clang-tidy/bugprone-unused-return-value.cpp
81 ↗(On Diff #165808)

I'd probably cut repeated parts of the pattern (starting from the second one) to make them fit 80 characters, e.g. like this:

// CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used

Same for the notes.

This revision is now accepted and ready to land.Sep 18 2018, 2:23 AM
JonasToth updated this revision to Diff 165926.Sep 18 2018, 3:42 AM
  • shorten warning checks
JonasToth marked an inline comment as done.Sep 18 2018, 3:44 AM
Harbormaster completed remote builds in B22780: Diff 165926.Sep 18 2018, 3:45 AM
Closed by commit rL342468: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value (authored by JonasToth). · Explain WhySep 18 2018, 4:50 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 18 2018, 4:50 AM

Revision Contents

PathSize
clang-tools-extra/
trunk/
test/
clang-tidy/
24 lines
69 lines

Diff 165940

clang-tools-extra/trunk/test/clang-tidy/bugprone-unused-return-value-custom.cpp

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines
} // namespace ns } // namespace ns
int fun(); int fun();
void fun(int); void fun(int);
void warning() { void warning() {
fun(); fun();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value returned by this function should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast the expression to void to silence this warning
(fun()); (fun());
// CHECK-MESSAGES: [[@LINE-1]]:4: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:4: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:4: note: cast {{.*}} this warning
ns::Outer::Inner ObjA1; ns::Outer::Inner ObjA1;
ObjA1.memFun(); ObjA1.memFun();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
ns::AliasName::Inner ObjA2; ns::AliasName::Inner ObjA2;
ObjA2.memFun(); ObjA2.memFun();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
ns::Derived ObjA3; ns::Derived ObjA3;
ObjA3.memFun(); ObjA3.memFun();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
ns::Type::staticFun(); ns::Type::staticFun();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
ns::ClassTemplate<int> ObjA4; ns::ClassTemplate<int> ObjA4;
ObjA4.memFun(); ObjA4.memFun();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
ns::ClassTemplate<int>::staticFun(); ns::ClassTemplate<int>::staticFun();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
} }
void noWarning() { void noWarning() {
auto R1 = fun(); auto R1 = fun();
ns::Outer::Inner ObjB1; ns::Outer::Inner ObjB1;
auto R2 = ObjB1.memFun(); auto R2 = ObjB1.memFun();
Show All 17 Lines

clang-tools-extra/trunk/test/clang-tidy/bugprone-unused-return-value.cpp

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines
int increment(int i) { int increment(int i) {
return i + 1; return i + 1;
} }
void useFuture(const std::future &fut); void useFuture(const std::future &fut);
void warning() { void warning() {
std::async(increment, 42); std::async(increment, 42);
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value returned by this function should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast the expression to void to silence this warning
std::async(std::launch::async, increment, 42); std::async(std::launch::async, increment, 42);
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
Foo F; Foo F;
std::launder(&F); std::launder(&F);
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
std::remove(nullptr, nullptr, 1); std::remove(nullptr, nullptr, 1);
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
std::remove_if(nullptr, nullptr, nullptr); std::remove_if(nullptr, nullptr, nullptr);
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
std::unique(nullptr, nullptr); std::unique(nullptr, nullptr);
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
std::unique_ptr<Foo> UPtr; std::unique_ptr<Foo> UPtr;
UPtr.release(); UPtr.release();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
std::string Str; std::string Str;
Str.empty(); Str.empty();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
std::vector<Foo> Vec; std::vector<Foo> Vec;
Vec.empty(); Vec.empty();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:3: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:3: note: cast {{.*}} this warning
// test discarding return values inside different kinds of statements // test discarding return values inside different kinds of statements
auto Lambda = [] { std::remove(nullptr, nullptr, 1); }; auto Lambda = [] { std::remove(nullptr, nullptr, 1); };
// CHECK-MESSAGES: [[@LINE-1]]:22: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:22: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:22: note: cast {{.*}} this warning
if (true) if (true)
std::remove(nullptr, nullptr, 1); std::remove(nullptr, nullptr, 1);
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:5: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:5: note: cast {{.*}} this warning
else if (true) else if (true)
std::remove(nullptr, nullptr, 1); std::remove(nullptr, nullptr, 1);
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:5: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:5: note: cast {{.*}} this warning
else else
std::remove(nullptr, nullptr, 1); std::remove(nullptr, nullptr, 1);
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:5: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:5: note: cast {{.*}} this warning
while (true) while (true)
std::remove(nullptr, nullptr, 1); std::remove(nullptr, nullptr, 1);
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:5: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:5: note: cast {{.*}} this warning
do do
std::remove(nullptr, nullptr, 1); std::remove(nullptr, nullptr, 1);
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:5: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:5: note: cast {{.*}} this warning
while (true); while (true);
for (;;) for (;;)
std::remove(nullptr, nullptr, 1); std::remove(nullptr, nullptr, 1);
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:5: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:5: note: cast {{.*}} this warning
for (std::remove(nullptr, nullptr, 1);;) for (std::remove(nullptr, nullptr, 1);;)
// CHECK-MESSAGES: [[@LINE-1]]:8: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:8: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:8: note: cast {{.*}} this warning
; ;
for (;; std::remove(nullptr, nullptr, 1)) for (;; std::remove(nullptr, nullptr, 1))
// CHECK-MESSAGES: [[@LINE-1]]:11: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:11: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:11: note: cast {{.*}} this warning
; ;
for (auto C : "foo") for (auto C : "foo")
std::remove(nullptr, nullptr, 1); std::remove(nullptr, nullptr, 1);
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:5: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:5: note: cast {{.*}} this warning
switch (1) { switch (1) {
case 1: case 1:
std::remove(nullptr, nullptr, 1); std::remove(nullptr, nullptr, 1);
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:5: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:5: note: cast {{.*}} this warning
break; break;
default: default:
std::remove(nullptr, nullptr, 1); std::remove(nullptr, nullptr, 1);
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:5: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:5: note: cast {{.*}} this warning
break; break;
} }
try { try {
std::remove(nullptr, nullptr, 1); std::remove(nullptr, nullptr, 1);
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:5: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:5: note: cast {{.*}} this warning
} catch (...) { } catch (...) {
std::remove(nullptr, nullptr, 1); std::remove(nullptr, nullptr, 1);
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: the value returned by this function should be used [bugprone-unused-return-value] // CHECK-NOTES: [[@LINE-1]]:5: warning: the value {{.*}} should be used
// CHECK-NOTES: [[@LINE-2]]:5: note: cast {{.*}} this warning
} }
} }
void noWarning() { void noWarning() {
auto AsyncRetval1 = std::async(increment, 42); auto AsyncRetval1 = std::async(increment, 42);
auto AsyncRetval2 = std::async(std::launch::async, increment, 42); auto AsyncRetval2 = std::async(std::launch::async, increment, 42);
Foo FNoWarning; Foo FNoWarning;
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines