This is an archive of the discontinued LLVM Phabricator instance.

Differential D52185

[clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace
ClosedPublic

Authored by JonasToth on Sep 17 2018, 12:30 PM.

Details

Reviewers
aaron.ballman
alexfh
hokein
Commits
rG724a826288d8: [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace
rCTE343198: [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace
rL343198: [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace

Diff Detail

Event Timeline

JonasToth created this revision.Sep 17 2018, 12:30 PM
Herald added subscribers: cfe-commits, xazax.hun. · View Herald TranscriptSep 17 2018, 12:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 27 2018, 5:19 AM
Closed by commit rL343198: [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace (authored by JonasToth). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 27 2018, 5:19 AM

Revision Contents

PathSize
test/
clang-tidy/
44 lines

Diff 165805

test/clang-tidy/bugprone-forward-declaration-namespace.cpp

// RUN: %check_clang_tidy %s bugprone-forward-declaration-namespace %t // RUN: %check_clang_tidy %s bugprone-forward-declaration-namespace %t
namespace { namespace {
// This is a declaration in a wrong namespace. // This is a declaration in a wrong namespace.
class T_A; class T_A;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration 'T_A' is never referenced, but a declaration with the same name found in another namespace 'na' [bugprone-forward-declaration-namespace] // CHECK-NOTES: :[[@LINE-1]]:7: warning: declaration 'T_A' is never referenced, but a declaration with the same name found in another namespace 'na' [bugprone-forward-declaration-namespace]
// CHECK-MESSAGES: note: a declaration of 'T_A' is found here // CHECK-NOTES: note: a declaration of 'T_A' is found here
// CHECK-MESSAGES: :[[@LINE-3]]:7: warning: no definition found for 'T_A', but a definition with the same name 'T_A' found in another namespace '(global)' [bugprone-forward-declaration-namespace] // CHECK-NOTES: :[[@LINE-3]]:7: warning: no definition found for 'T_A', but a definition with the same name 'T_A' found in another namespace '(global)' [bugprone-forward-declaration-namespace]
// CHECK-MESSAGES: note: a definition of 'T_A' is found here // CHECK-NOTES: note: a definition of 'T_A' is found here
} }
namespace na { namespace na {
// This is a declaration in a wrong namespace. // This is a declaration in a wrong namespace.
class T_A; class T_A;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration 'T_A' is never referenced, but a declaration with the same name found in another namespace '(anonymous)' // CHECK-NOTES: :[[@LINE-1]]:7: warning: declaration 'T_A' is never referenced, but a declaration with the same name found in another namespace '(anonymous)'
// CHECK-MESSAGES: note: a declaration of 'T_A' is found here // CHECK-NOTES: note: a declaration of 'T_A' is found here
// CHECK-MESSAGES: :[[@LINE-3]]:7: warning: no definition found for 'T_A', but a definition with the same name 'T_A' found in another namespace '(global)' // CHECK-NOTES: :[[@LINE-3]]:7: warning: no definition found for 'T_A', but a definition with the same name 'T_A' found in another namespace '(global)'
// CHECK-MESSAGES: note: a definition of 'T_A' is found here // CHECK-NOTES: note: a definition of 'T_A' is found here
} }
class T_A; class T_A;
class T_A { class T_A {
int x; int x;
}; };
class NESTED; class NESTED;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: no definition found for 'NESTED', but a definition with the same name 'NESTED' found in another namespace '(anonymous namespace)::nq::(anonymous)' // CHECK-NOTES: :[[@LINE-1]]:7: warning: no definition found for 'NESTED', but a definition with the same name 'NESTED' found in another namespace '(anonymous namespace)::nq::(anonymous)'
// CHECK-MESSAGES: note: a definition of 'NESTED' is found here // CHECK-NOTES: note: a definition of 'NESTED' is found here
namespace { namespace {
namespace nq { namespace nq {
namespace { namespace {
class NESTED {}; class NESTED {};
} }
} }
} }
namespace na { namespace na {
class T_B; class T_B;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration 'T_B' is never referenced, but a declaration with the same name found in another namespace 'nb' // CHECK-NOTES: :[[@LINE-1]]:7: warning: declaration 'T_B' is never referenced, but a declaration with the same name found in another namespace 'nb'
// CHECK-MESSAGES: note: a declaration of 'T_B' is found here // CHECK-NOTES: note: a declaration of 'T_B' is found here
// CHECK-MESSAGES: :[[@LINE-3]]:7: warning: no definition found for 'T_B', but a definition with the same name 'T_B' found in another namespace 'nb' // CHECK-NOTES: :[[@LINE-3]]:7: warning: no definition found for 'T_B', but a definition with the same name 'T_B' found in another namespace 'nb'
// CHECK-MESSAGES: note: a definition of 'T_B' is found here // CHECK-NOTES: note: a definition of 'T_B' is found here
} }
namespace nb { namespace nb {
class T_B; class T_B;
} }
namespace nb { namespace nb {
class T_B { class T_B {
int x; int x;
}; };
} }
namespace na { namespace na {
class T_B; class T_B;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration 'T_B' is never referenced, but a declaration with the same name found in another namespace 'nb' // CHECK-NOTES: :[[@LINE-1]]:7: warning: declaration 'T_B' is never referenced, but a declaration with the same name found in another namespace 'nb'
// CHECK-MESSAGES: note: a declaration of 'T_B' is found here // CHECK-NOTES: note: a declaration of 'T_B' is found here
// CHECK-MESSAGES: :[[@LINE-3]]:7: warning: no definition found for 'T_B', but a definition with the same name 'T_B' found in another namespace 'nb' // CHECK-NOTES: :[[@LINE-3]]:7: warning: no definition found for 'T_B', but a definition with the same name 'T_B' found in another namespace 'nb'
// CHECK-MESSAGES: note: a definition of 'T_B' is found here // CHECK-NOTES: note: a definition of 'T_B' is found here
} }
// A simple forward declaration. Although it is never used, but no declaration // A simple forward declaration. Although it is never used, but no declaration
// with the same name is found in other namespace. // with the same name is found in other namespace.
class OUTSIDER; class OUTSIDER;
namespace na { namespace na {
// This class is referenced declaration, we don't generate warning. // This class is referenced declaration, we don't generate warning.
Show All 13 Lines
namespace nd { namespace nd {
class OUTSIDER_1; class OUTSIDER_1;
void f(OUTSIDER_1 *); void f(OUTSIDER_1 *);
} }
namespace nb { namespace nb {
class OUTSIDER_1; class OUTSIDER_1;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration 'OUTSIDER_1' is never referenced, but a declaration with the same name found in another namespace 'na' // CHECK-NOTES: :[[@LINE-1]]:7: warning: declaration 'OUTSIDER_1' is never referenced, but a declaration with the same name found in another namespace 'na'
// CHECK-MESSAGES: note: a declaration of 'OUTSIDER_1' is found here // CHECK-NOTES: note: a declaration of 'OUTSIDER_1' is found here
} }
namespace na { namespace na {
template<typename T> template<typename T>
class T_C; class T_C;
} }
Show All 32 Lines
}; };
// We ignore class template specialization. // We ignore class template specialization.
extern template class T_TEMP_1<char>; extern template class T_TEMP_1<char>;
} }
namespace nd { namespace nd {
class D; class D;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration 'D' is never referenced, but a declaration with the same name found in another namespace 'nd::ne' // CHECK-NOTES: :[[@LINE-1]]:7: warning: declaration 'D' is never referenced, but a declaration with the same name found in another namespace 'nd::ne'
// CHECK-MESSAGES: note: a declaration of 'D' is found here // CHECK-NOTES: note: a declaration of 'D' is found here
} }
namespace nd { namespace nd {
namespace ne { namespace ne {
class D; class D;
} }
} }
Show All 12 Lines