This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add V128 value type to binary format
ClosedPublic

Authored by tlively on Sep 14 2018, 10:39 AM.

Diff Detail

Event Timeline

tlively created this revision.Sep 14 2018, 10:39 AM
tlively updated this revision to Diff 165538.Sep 14 2018, 10:55 AM
  • Add to switch in MCTargetDesc

Is this enough to add SIMD to one of our existing binary-format tests?

tlively updated this revision to Diff 166052.Sep 18 2018, 5:18 PM
  • add tests, fix calls to make tests work, and remove dead code.
aheejin added inline comments.Sep 18 2018, 5:27 PM
test/CodeGen/WebAssembly/call.ll
15

Nit: v128_nullary or v16i8_nullary for symmetry?

124

Maybe we can make this call-related stuff another CL, which is not relevant to V128?

test/MC/WebAssembly/types.ll
1

What's the purpose of this test?

10

No argument for rest of functions?

18

Nit: indentation 2 spaces

tlively marked 3 inline comments as done.Sep 18 2018, 6:11 PM
tlively added inline comments.
test/MC/WebAssembly/types.ll
1

It checks that the ValTypes are emitted to an object file correctly, including the new V128 one.

tlively updated this revision to Diff 166055.Sep 18 2018, 6:17 PM
tlively marked an inline comment as done.
  • Address comments
aheejin added inline comments.Sep 19 2018, 11:21 AM
test/MC/WebAssembly/types.ll
10

Oh, I wasn't suggesting deleting the argument... actually was suggesting adding it to other functions too (for symmetry), but if you don't think we need it, that's probably fine.

aheejin added inline comments.Sep 19 2018, 11:29 AM
test/MC/WebAssembly/types.ll
1

Nit: Then probably it would make more sense to move this to D52254..?

tlively added inline comments.Sep 19 2018, 11:45 AM
test/MC/WebAssembly/types.ll
1

I think at least part of this test belongs in this CL since it's the only thing testing the ObjectYAML support for V128, but splitting up the test file into two commits is probably more trouble than it's worth, so I would prefer to just keep it here.

aheejin added inline comments.Sep 19 2018, 11:47 AM
test/MC/WebAssembly/types.ll
1

Yeah that makes sense.

@aheejin is this blocked on anything else?

aheejin accepted this revision.Sep 20 2018, 2:55 PM

I was not sure if what @dschuff asked was done. If it was I’m ok with the change.

This revision is now accepted and ready to land.Sep 20 2018, 2:55 PM
This revision was automatically updated to reflect the committed changes.