This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Don't override the preamble while completing inside it, it doesn't work.
ClosedPublic

Authored by sammccall on Sep 13 2018, 9:57 PM.

Details

Summary

To stay fast, enable single-file-mode instead. This is fine since completions
in the preamble are simple.

The net effect for now is to suppress the spurious TopLevel completions when
completing inside the preamble.
Once Sema has include directive completion, this will be more important.

Diff Detail

Repository
rL LLVM

Event Timeline

sammccall created this revision.Sep 13 2018, 9:57 PM
ilya-biryukov accepted this revision.Sep 14 2018, 2:29 AM

Neat, I was unaware that single-file mode completions actually work nicely in that case.
LGTM!

This revision is now accepted and ready to land.Sep 14 2018, 2:29 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.